qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@us.ibm.com>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>
Subject: [Qemu-devel] [PATCH 1/1] Make the e1000 the default network adapter for the pc target.
Date: Fri, 14 Aug 2009 11:23:21 -0500	[thread overview]
Message-ID: <1250267001-4431-1-git-send-email-aliguori@us.ibm.com> (raw)

The ne2k is an ancient card that performs pretty terribly under QEMU.  In many
modern OSes, there is no longer drivers available for the ne2k.

Switch the default network adapter to e1000.  This card is more widely
suppported and performs rather well under QEMU.  There may be very old OSes
that had a ne2k driver but not an e1000 driver but I think this is likely the
exception.

I think the average user is better served with an e1000 vs ne2k.

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
---
 hw/pc.c         |    4 ++--
 qemu-options.hx |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/pc.c b/hw/pc.c
index 5664d1b..11b8618 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -1264,7 +1264,7 @@ static void pc_init1(ram_addr_t ram_size,
             continue;
 
         if (model == NULL)
-            model = "ne2k_pci";
+            model = "e1000";
         snprintf(nic_oprom, sizeof(nic_oprom), "pxe-%s.bin", model);
 
         oprom_area_size += load_option_rom(nic_oprom, 0xc0000 + oprom_area_size,
@@ -1347,7 +1347,7 @@ static void pc_init1(ram_addr_t ram_size,
         if (!pci_enabled || (nd->model && strcmp(nd->model, "ne2k_isa") == 0))
             pc_init_ne2k_isa(nd, isa_irq);
         else
-            pci_nic_init(nd, "ne2k_pci", NULL);
+            pci_nic_init(nd, "e1000", NULL);
     }
 
     piix4_acpi_system_hot_add_init();
diff --git a/qemu-options.hx b/qemu-options.hx
index 03abb5c..e3bd314 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -828,7 +828,7 @@ DEF("net", HAS_ARG, QEMU_OPTION_net,
 STEXI
 @item -net nic[,vlan=@var{n}][,macaddr=@var{mac}][,model=@var{type}][,name=@var{name}][,addr=@var{addr}][,vectors=@var{v}]
 Create a new Network Interface Card and connect it to VLAN @var{n} (@var{n}
-= 0 is the default). The NIC is an ne2k_pci by default on the PC
+= 0 is the default). The NIC is an e1000 by default on the PC
 target. Optionally, the MAC address can be changed to @var{mac}, the
 device address set to @var{addr} (PCI cards only),
 and a @var{name} can be assigned for use in monitor commands.
-- 
1.6.2.5

             reply	other threads:[~2009-08-14 16:23 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-14 16:23 Anthony Liguori [this message]
2009-08-15 21:58 ` [Qemu-devel] Re: [PATCH 1/1] Make the e1000 the default network adapterfor the pc target Sebastian Herbszt
2009-08-17 10:34 ` [Qemu-devel] [PATCH 1/1] Make the e1000 the default network adapter for " Mark McLoughlin
2009-08-24 15:12   ` Anthony Liguori
2009-08-24 15:36     ` Gerd Hoffmann
2009-08-24 16:14       ` Anthony Liguori
2009-08-25 10:45 ` Avi Kivity
2009-08-25 12:39   ` Anthony Liguori
2009-08-25 15:55     ` Avi Kivity
2009-08-25 13:23   ` Lennart Sorensen
2009-08-25 13:34     ` Anthony Liguori
2009-08-25 14:23       ` Lennart Sorensen
2009-08-25 16:00       ` Avi Kivity
2009-08-25 15:58     ` Avi Kivity
2009-08-25 16:30       ` Lennart Sorensen
2009-08-25 16:39         ` Anthony Liguori
2009-08-25 16:56           ` Avi Kivity
2009-08-25 17:11             ` Lennart Sorensen
2009-08-25 17:13               ` Avi Kivity
2009-08-25 18:19                 ` Anthony Liguori
2009-08-26  8:32                   ` Avi Kivity
2009-08-25 17:28               ` Reimar Döffinger
2009-08-26  5:47           ` Amit Shah
2009-08-25 20:20       ` [Qemu-devel] " Bjørn Mork
2009-08-26  9:57         ` Avi Kivity
2009-08-25 13:51   ` [Qemu-devel] " Stefan Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1250267001-4431-1-git-send-email-aliguori@us.ibm.com \
    --to=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).