From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MduHs-0002b7-E7 for qemu-devel@nongnu.org; Wed, 19 Aug 2009 19:09:48 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MduHn-0002XW-O1 for qemu-devel@nongnu.org; Wed, 19 Aug 2009 19:09:47 -0400 Received: from [199.232.76.173] (port=49915 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MduHn-0002XF-Hb for qemu-devel@nongnu.org; Wed, 19 Aug 2009 19:09:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46889) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MduHm-0005be-Sk for qemu-devel@nongnu.org; Wed, 19 Aug 2009 19:09:43 -0400 From: Luiz Capitulino Date: Wed, 19 Aug 2009 20:07:54 -0300 Message-Id: <1250723280-3509-24-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1250723280-3509-1-git-send-email-lcapitulino@redhat.com> References: <1250723280-3509-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] [PATCH 23/29] monitor: fail when 'i' type is greater than 32-bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com, avi@redhat.com The 'i' argument type is for 32-bit only and most handlers will use an 'int' to store its value. It's better to fail gracefully when the user enters a value greater than 32-bit than to get subtle casting bugs. Signed-off-by: Luiz Capitulino --- monitor.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index b067b24..519bae0 100644 --- a/monitor.c +++ b/monitor.c @@ -2820,6 +2820,12 @@ static const mon_cmd_t *monitor_parse_command(Monitor *mon, } if (get_expr(mon, &val, &p)) goto fail; + /* Check if 'i' is greater than 32-bit */ + if ((c == 'i') && ((val >> 32) & 0xffffffff)) { + monitor_printf(mon, "\'%s\' has failed: ", cmdname); + monitor_printf(mon, "integer is for 32-bit values\n"); + goto fail; + } qdict_add_qint(qdict, key, qint_from_int64(val)); } break; -- 1.6.4.67.gea5b1