From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MduGv-0001lQ-5C for qemu-devel@nongnu.org; Wed, 19 Aug 2009 19:08:49 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MduGq-0001gN-Fi for qemu-devel@nongnu.org; Wed, 19 Aug 2009 19:08:48 -0400 Received: from [199.232.76.173] (port=49885 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MduGq-0001gE-2l for qemu-devel@nongnu.org; Wed, 19 Aug 2009 19:08:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5907) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MduGp-0005TQ-Ht for qemu-devel@nongnu.org; Wed, 19 Aug 2009 19:08:43 -0400 From: Luiz Capitulino Date: Wed, 19 Aug 2009 20:07:38 -0300 Message-Id: <1250723280-3509-8-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1250723280-3509-1-git-send-email-lcapitulino@redhat.com> References: <1250723280-3509-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] [PATCH 07/29] monitor: Setup a QDict with arguments to handlers List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com, avi@redhat.com With this commit monitor_handle_command() will be able to setup a QDict with arguments to command handlers. However, the current 'args[]' method is still being used, next changes will port commands to get their arguments from the dictionary. Two changes are worth noting: 1. The '/' argument type always adds the following standard keys in the dictionary: 'count', 'format' and 'size'. This way, the argument name used in the 'args_type' string doesn't matter 2. The optional argument type '?' doesn't need to pass the additional 'has_arg' argument, hanlders can do the same check with qdict_exists() Signed-off-by: Luiz Capitulino --- monitor.c | 18 ++++++++++++++++++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index 89b9467..d3b62e3 100644 --- a/monitor.c +++ b/monitor.c @@ -44,6 +44,9 @@ #include "migration.h" #include "kvm.h" #include "acl.h" +#include "qint.h" +#include "qdict.h" +#include "qstring.h" //#define DEBUG //#define DEBUG_COMPLETION @@ -2595,6 +2598,7 @@ static void monitor_handle_command(Monitor *mon, const char *cmdline) char cmdname[256]; char buf[1024]; char *key; + QDict *qdict; void *str_allocated[MAX_ARGS]; void *args[MAX_ARGS]; void (*handler_0)(Monitor *mon); @@ -2639,6 +2643,8 @@ static void monitor_handle_command(Monitor *mon, const char *cmdline) return; } + qdict = qdict_new(); + for(i = 0; i < MAX_ARGS; i++) str_allocated[i] = NULL; @@ -2696,6 +2702,8 @@ static void monitor_handle_command(Monitor *mon, const char *cmdline) goto fail; } args[nb_args++] = str; + if (str) + qdict_add_qstring(qdict, key, qstring_from_str(str)); } break; case '/': @@ -2777,12 +2785,16 @@ static void monitor_handle_command(Monitor *mon, const char *cmdline) args[nb_args++] = (void*)(long)count; args[nb_args++] = (void*)(long)format; args[nb_args++] = (void*)(long)size; + qdict_add_qint(qdict, "count", qint_from_int(count)); + qdict_add_qint(qdict, "format", qint_from_int(format)); + qdict_add_qint(qdict, "size", qint_from_int(size)); } break; case 'i': case 'l': { int64_t val; + int dict_add = 1; while (qemu_isspace(*p)) p++; @@ -2805,6 +2817,7 @@ static void monitor_handle_command(Monitor *mon, const char *cmdline) typestr++; if (nb_args >= MAX_ARGS) goto error_args; + dict_add = has_arg; args[nb_args++] = (void *)(long)has_arg; if (!has_arg) { if (nb_args >= MAX_ARGS) @@ -2820,6 +2833,8 @@ static void monitor_handle_command(Monitor *mon, const char *cmdline) if (nb_args >= MAX_ARGS) goto error_args; args[nb_args++] = (void *)(long)val; + if (dict_add) + qdict_add_qint(qdict, key, qint_from_int64(val)); } else { if ((nb_args + 1) >= MAX_ARGS) goto error_args; @@ -2829,6 +2844,7 @@ static void monitor_handle_command(Monitor *mon, const char *cmdline) args[nb_args++] = (void *)0; #endif args[nb_args++] = (void *)(long)(val & 0xffffffff); + qdict_add_qint(qdict, key, qint_from_int64(val)); } } break; @@ -2856,6 +2872,7 @@ static void monitor_handle_command(Monitor *mon, const char *cmdline) if (nb_args >= MAX_ARGS) goto error_args; args[nb_args++] = (void *)(long)has_option; + qdict_add_qint(qdict, key, qint_from_int(has_option)); } break; default: @@ -2932,6 +2949,7 @@ static void monitor_handle_command(Monitor *mon, const char *cmdline) qemu_free(key); for(i = 0; i < MAX_ARGS; i++) qemu_free(str_allocated[i]); + QDECREF(qdict); } static void cmd_completion(const char *name, const char *list) -- 1.6.4.67.gea5b1