From: Glauber Costa <glommer@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com
Subject: [Qemu-devel] [PATCH 1/2] unlock iothread before running vpu
Date: Tue, 25 Aug 2009 18:13:35 -0400 [thread overview]
Message-ID: <1251238416-5088-2-git-send-email-glommer@redhat.com> (raw)
In-Reply-To: <1251238416-5088-1-git-send-email-glommer@redhat.com>
Signed-off-by: Glauber Costa <glommer@redhat.com>
---
kvm-all.c | 4 ++++
qemu-common.h | 4 ++++
vl.c | 9 ++++-----
3 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/kvm-all.c b/kvm-all.c
index f669c3a..d9d7e06 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -591,7 +591,11 @@ int kvm_cpu_exec(CPUState *env)
}
kvm_arch_pre_run(env, run);
+
+ qemu_mutex_unlock_iothread();
ret = kvm_vcpu_ioctl(env, KVM_RUN, 0);
+ qemu_mutex_lock_iothread();
+
kvm_arch_post_run(env, run);
if (ret == -EINTR || ret == -EAGAIN) {
diff --git a/qemu-common.h b/qemu-common.h
index 74ac88f..69486ed 100644
--- a/qemu-common.h
+++ b/qemu-common.h
@@ -207,6 +207,10 @@ void qemu_notify_event(void);
void qemu_cpu_kick(void *env);
int qemu_cpu_self(void *env);
+
+void qemu_mutex_lock_iothread(void);
+void qemu_mutex_unlock_iothread(void);
+
#ifdef CONFIG_USER_ONLY
#define qemu_init_vcpu(env) do { } while (0)
#else
diff --git a/vl.c b/vl.c
index c164f45..aa5047e 100644
--- a/vl.c
+++ b/vl.c
@@ -3595,14 +3595,13 @@ void qemu_notify_event(void)
}
}
-#define qemu_mutex_lock_iothread() do { } while (0)
-#define qemu_mutex_unlock_iothread() do { } while (0)
-
void vm_stop(int reason)
{
do_vm_stop(reason);
}
+void qemu_mutex_lock_iothread(void) {}
+void qemu_mutex_unlock_iothread(void) {}
#else /* CONFIG_IOTHREAD */
#include "qemu-thread.h"
@@ -3788,7 +3787,7 @@ static void qemu_signal_lock(unsigned int msecs)
qemu_mutex_unlock(&qemu_fair_mutex);
}
-static void qemu_mutex_lock_iothread(void)
+void qemu_mutex_lock_iothread(void)
{
if (kvm_enabled()) {
qemu_mutex_lock(&qemu_fair_mutex);
@@ -3798,7 +3797,7 @@ static void qemu_mutex_lock_iothread(void)
qemu_signal_lock(100);
}
-static void qemu_mutex_unlock_iothread(void)
+void qemu_mutex_unlock_iothread(void)
{
qemu_mutex_unlock(&qemu_global_mutex);
}
--
1.6.2.2
next prev parent reply other threads:[~2009-08-26 2:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-25 22:13 [Qemu-devel] [PATCH 0/2] io-thread fixes Glauber Costa
2009-08-25 22:13 ` Glauber Costa [this message]
2009-08-25 22:13 ` [Qemu-devel] [PATCH 2/2] do not issue ioctl from within the io thread Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1251238416-5088-2-git-send-email-glommer@redhat.com \
--to=glommer@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).