qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Weil <weil@mail.berlios.de>
To: Gerd Hoffmann <kraxel@redhat.com>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH] mips malta: Fix fdc regression
Date: Thu, 27 Aug 2009 08:17:52 +0200	[thread overview]
Message-ID: <1251353872-16463-1-git-send-email-weil@mail.berlios.de> (raw)
In-Reply-To: <4A961C81.1040500@mail.berlios.de>

8baf73adf664e79eae201c3f618078a220a661d9 (qdev/isa: convert fdc)
breaks MIPS Malta:

Tried to create isa device isa-fdc with no isa bus present

Fix this by creating an isa bus for piix4
and convert initialization code for i8042
in mips_malta.c to new style (copy from pc.c)

Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
 hw/mips_malta.c |    6 +++++-
 hw/piix_pci.c   |    1 +
 2 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/hw/mips_malta.c b/hw/mips_malta.c
index d8fa264..e4421a6 100644
--- a/hw/mips_malta.c
+++ b/hw/mips_malta.c
@@ -764,6 +764,7 @@ void mips_malta_init (ram_addr_t ram_size,
     target_long bios_size;
     int64_t kernel_entry;
     PCIBus *pci_bus;
+    ISADevice *isa_dev;
     CPUState *env;
     RTCState *rtc_state;
     fdctrl_t *floppy_controller;
@@ -919,7 +920,10 @@ void mips_malta_init (ram_addr_t ram_size,
     DMA_init(0);
 
     /* Super I/O */
-    i8042_init(i8259[1], i8259[12], 0x60);
+    isa_dev = isa_create_simple("i8042", 0x60, 0x64);
+    isa_connect_irq(isa_dev, 0, i8259[1]);
+    isa_connect_irq(isa_dev, 1, i8259[12]);
+ 
     rtc_state = rtc_init(0x70, i8259[8], 2000);
     serial_init(0x3f8, i8259[4], 115200, serial_hds[0]);
     serial_init(0x2f8, i8259[3], 115200, serial_hds[1]);
diff --git a/hw/piix_pci.c b/hw/piix_pci.c
index e2ddf4b..736fca4 100644
--- a/hw/piix_pci.c
+++ b/hw/piix_pci.c
@@ -362,6 +362,7 @@ static void piix4_initfn(PCIDevice *d)
 {
     uint8_t *pci_conf;
 
+    isa_bus_new(&d->qdev);
     register_savevm("PIIX4", 0, 2, piix_save, piix_load, d);
 
     pci_conf = d->config;
-- 
1.5.6.5

  reply	other threads:[~2009-08-27  6:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-27  5:41 [Qemu-devel] [BUG] Regression for machine using fdc Stefan Weil
2009-08-27  6:17 ` Stefan Weil [this message]
2009-08-28 11:47   ` [Qemu-devel] Re: [PATCH] mips malta: Fix fdc regression Stefan Weil
2009-08-28 11:48     ` [Qemu-devel] " Stefan Weil
2009-08-28 17:37       ` [Qemu-devel] [PATCH] mips malta: Fix fdc regression and use qdev for i8042 setup Stefan Weil
2009-08-31  6:33         ` [Qemu-devel] " Gerd Hoffmann
2009-08-28 18:47       ` [Qemu-devel] Re: [PATCH] mips malta: Fix fdc regression Stefan Weil
2009-08-28 11:56     ` [Qemu-devel] [PATCH] mips malta: Use qdev for i8042 setup Stefan Weil
2009-08-28 12:13       ` [Qemu-devel] " Stefan Weil
2009-08-27  6:26 ` [Qemu-devel] [BUG] Regression for machine using fdc Stefan Weil
2009-08-27  8:06   ` Gerd Hoffmann
2009-08-27 19:46   ` Hervé Poussineau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1251353872-16463-1-git-send-email-weil@mail.berlios.de \
    --to=weil@mail.berlios.de \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).