From: Glauber Costa <glommer@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com
Subject: [Qemu-devel] [PATCH] re-set rtc date on reset handler
Date: Tue, 1 Sep 2009 12:22:34 -0400 [thread overview]
Message-ID: <1251822154-5423-1-git-send-email-glommer@redhat.com> (raw)
guests without a stable timesource such as kvm-clock will grab the wallclock
from our rtc chip. However, we only sync the date when we first launch qemu.
If a guest goes through a series of reboot cycles, it will slowly see time
getting far behind the host.
The proposal of this patch is to set the date to host clock again in the reset
handler. With this patch, I see a Fedora guest keeping its clock in sync upon
an ulimited number of reboots.
Signed-off-by: Glauber Costa <glommer@redhat.com>
---
hw/mc146818rtc.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c
index 5c8676e..e71a9da 100644
--- a/hw/mc146818rtc.c
+++ b/hw/mc146818rtc.c
@@ -586,6 +586,8 @@ static void rtc_reset(void *opaque)
if (rtc_td_hack)
s->irq_coalesced = 0;
#endif
+
+ rtc_set_date_from_host(s);
}
RTCState *rtc_init_sqw(int base, qemu_irq irq, qemu_irq sqw_irq, int base_year)
--
1.6.2.2
next reply other threads:[~2009-09-01 15:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-01 16:22 Glauber Costa [this message]
2009-09-01 16:56 ` [Qemu-devel] [PATCH] re-set rtc date on reset handler Blue Swirl
2009-09-01 23:00 ` Glauber Costa
2009-09-08 14:55 ` Dor Laor
2009-09-08 16:15 ` [Qemu-devel] " Jan Kiszka
2009-09-08 16:50 ` Jan Kiszka
2009-09-08 17:00 ` Jan Kiszka
2009-09-09 12:28 ` Dor Laor
2009-09-09 12:57 ` Jan Kiszka
2009-09-09 13:27 ` Avi Kivity
2009-09-09 13:31 ` Jan Kiszka
2009-09-09 15:04 ` Avi Kivity
2009-09-09 15:34 ` Anthony Liguori
2009-09-09 16:09 ` Gleb Natapov
2009-09-09 17:52 ` Anthony Liguori
2009-09-09 18:40 ` Gleb Natapov
2009-09-09 18:50 ` Anthony Liguori
2009-09-09 18:25 ` Avi Kivity
2009-09-09 18:33 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1251822154-5423-1-git-send-email-glommer@redhat.com \
--to=glommer@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).