From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MjIWR-0005Kq-8e
	for qemu-devel@nongnu.org; Thu, 03 Sep 2009 16:03:07 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MjIWM-0005G9-Cs
	for qemu-devel@nongnu.org; Thu, 03 Sep 2009 16:03:06 -0400
Received: from [199.232.76.173] (port=51495 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MjIWM-0005Fp-90
	for qemu-devel@nongnu.org; Thu, 03 Sep 2009 16:03:02 -0400
Received: from mx20.gnu.org ([199.232.41.8]:55909)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <markmc@redhat.com>) id 1MjIWK-0007AI-TB
	for qemu-devel@nongnu.org; Thu, 03 Sep 2009 16:03:01 -0400
Received: from mx1.redhat.com ([209.132.183.28])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <markmc@redhat.com>) id 1MjIWF-0001Jz-Ex
	for qemu-devel@nongnu.org; Thu, 03 Sep 2009 16:02:55 -0400
From: Mark McLoughlin <markmc@redhat.com>
In-Reply-To: <d9c105ea0909031031g463aa731j846dd73d4c158ebc@mail.gmail.com>
References: <d9c105ea0909031031g463aa731j846dd73d4c158ebc@mail.gmail.com>
Content-Type: text/plain
Date: Thu, 03 Sep 2009 21:01:54 +0100
Message-Id: <1252008114.3084.136.camel@blaa>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] qemu-kvm: fix segfault when running kvm
 without /dev/kvm,  falling back to non-accelerated mode
Reply-To: Mark McLoughlin <markmc@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dustin Kirkland <kirkland@canonical.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org

On Thu, 2009-09-03 at 12:31 -0500, Dustin Kirkland wrote:
> qemu-kvm: fix segfault when running kvm without /dev/kvm, falling back
> to non-accelerated mode
> 
> We're seeing segfaults on systems without access to /dev/kvm.  It
> looks like the global kvm_allowed is being set just a little too late
> in vl.c.  This patch moves the kvm initialization a bit higher in the
> vl.c main, just after options processing, and solves the segfaults.
> We're carrying this patch in Ubuntu 9.10 Alpha.  Please apply
> upstream, or advise if and why this might not be the optimal solution.

Ah discussion about an alternative fix for this fizzled out recently:

  http://www.mail-archive.com/kvm@vger.kernel.org/msg19890.html

Cheers,
Mark.