From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MjJXB-0000tM-Hp for qemu-devel@nongnu.org; Thu, 03 Sep 2009 17:07:57 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MjJX6-0000sq-1g for qemu-devel@nongnu.org; Thu, 03 Sep 2009 17:07:56 -0400 Received: from [199.232.76.173] (port=44006 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MjJX5-0000sn-Ve for qemu-devel@nongnu.org; Thu, 03 Sep 2009 17:07:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9813) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MjJX5-0001hS-Ff for qemu-devel@nongnu.org; Thu, 03 Sep 2009 17:07:51 -0400 Subject: Re: [Qemu-devel] [PATCH v3 00/29] QMonitor From: Mark McLoughlin In-Reply-To: <1251484052-3939-1-git-send-email-lcapitulino@redhat.com> References: <1251484052-3939-1-git-send-email-lcapitulino@redhat.com> Content-Type: text/plain Date: Thu, 03 Sep 2009 22:06:52 +0100 Message-Id: <1252012012.3084.143.camel@blaa> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Reply-To: Mark McLoughlin List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, avi@redhat.com On Fri, 2009-08-28 at 15:27 -0300, Luiz Capitulino wrote: > Basically, this series introduces high-level data types (QInt, QString, > QDict) and port all Monitor command handlers to use them to receive > arguments. Very nice, carefully prepared series. Well done. It all looks good to me. I even went through each of the command conversions to verify that the parameter names in the implementation matched the names in the format and that optional parameters are handled correctly etc. I couldn't spot a single issue. Acked-by: Mark McLoughlin Cheers, Mark.