From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MkiUI-000646-Cu
	for qemu-devel@nongnu.org; Mon, 07 Sep 2009 13:58:46 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MkiUD-00060l-KG
	for qemu-devel@nongnu.org; Mon, 07 Sep 2009 13:58:45 -0400
Received: from [199.232.76.173] (port=57415 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MkiUD-00060U-74
	for qemu-devel@nongnu.org; Mon, 07 Sep 2009 13:58:41 -0400
Received: from mx1.redhat.com ([209.132.183.28]:22744)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <markmc@redhat.com>) id 1MkiUC-0006TD-FT
	for qemu-devel@nongnu.org; Mon, 07 Sep 2009 13:58:40 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n87Hwc2N025519
	for <qemu-devel@nongnu.org>; Mon, 7 Sep 2009 13:58:38 -0400
Subject: Re: [Qemu-devel] [PATCH] virtio-blk: add msi support.
From: Mark McLoughlin <markmc@redhat.com>
In-Reply-To: <1250074044-24667-1-git-send-email-kraxel@redhat.com>
References: <1250074044-24667-1-git-send-email-kraxel@redhat.com>
Content-Type: text/plain
Date: Mon, 07 Sep 2009 18:57:38 +0100
Message-Id: <1252346258.3056.73.camel@blaa>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Reply-To: Mark McLoughlin <markmc@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On Wed, 2009-08-12 at 12:47 +0200, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  hw/pc.c         |    4 ++++
>  hw/virtio-pci.c |    8 ++++++--
>  2 files changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/pc.c b/hw/pc.c
> index cc6e7e8..cccb865 100644
> --- a/hw/pc.c
> +++ b/hw/pc.c
> @@ -1487,6 +1487,10 @@ static QEMUMachine pc_machine_v0_10 = {
>              .driver   = "virtio-net-pci",
>              .property = "vectors",
>              .value    = stringify(0),
> +        },{
> +            .driver   = "virtio-blk-pci",
> +            .property = "vectors",
> +            .value    = stringify(0),

This means that MSI is enabled for virtio-blk with the pc-0.11 machine
type.

Shouldn't we add a pc-0.12 machine type and disable MSI for pc-0.11?

Cheers,
Mark.