qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH v2 11/23] convert pty chardev to QemuOpts.
Date: Thu, 10 Sep 2009 10:58:43 +0200	[thread overview]
Message-ID: <1252573135-27688-12-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1252573135-27688-1-git-send-email-kraxel@redhat.com>


Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 qemu-char.c |   13 +++++++------
 1 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/qemu-char.c b/qemu-char.c
index bff160e..a557b54 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -956,7 +956,7 @@ static void pty_chr_close(struct CharDriverState *chr)
     qemu_chr_event(chr, CHR_EVENT_CLOSED);
 }
 
-static CharDriverState *qemu_chr_open_pty(void)
+static CharDriverState *qemu_chr_open_pty(QemuOpts *opts)
 {
     CharDriverState *chr;
     PtyCharDriver *s;
@@ -986,6 +986,7 @@ static CharDriverState *qemu_chr_open_pty(void)
     len = strlen(q_ptsname(s->fd)) + 5;
     chr->filename = qemu_malloc(len);
     snprintf(chr->filename, len, "pty:%s", q_ptsname(s->fd));
+    qemu_opt_set(opts, "path", q_ptsname(s->fd));
     fprintf(stderr, "char device redirected to %s\n", q_ptsname(s->fd));
 
     chr->opaque = s;
@@ -2225,8 +2226,9 @@ static QemuOpts *qemu_chr_parse_compat(const char *label, const char *filename)
     if (NULL == opts)
         return NULL;
 
-    if (strcmp(filename, "null") == 0) {
-        qemu_opt_set(opts, "backend", "null");
+    if (strcmp(filename, "null") == 0 ||
+        strcmp(filename, "pty") == 0) {
+        qemu_opt_set(opts, "backend", filename);
         return opts;
     }
     if (strstart(filename, "file:", &p)) {
@@ -2282,6 +2284,7 @@ static const struct {
 #else
     { .name = "file",      .open = qemu_chr_open_file_out },
     { .name = "pipe",      .open = qemu_chr_open_pipe },
+    { .name = "pty",       .open = qemu_chr_open_pty },
 #endif
 };
 
@@ -2353,9 +2356,7 @@ CharDriverState *qemu_chr_open(const char *label, const char *filename, void (*i
         chr = qemu_chr_open_msmouse();
     } else
 #ifndef _WIN32
-    if (!strcmp(filename, "pty")) {
-        chr = qemu_chr_open_pty();
-    } else if (!strcmp(filename, "stdio")) {
+    if (!strcmp(filename, "stdio")) {
         chr = qemu_chr_open_stdio();
     } else
 #if defined(__linux__)
-- 
1.6.2.5

  parent reply	other threads:[~2009-09-10  8:59 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-10  8:58 [Qemu-devel] [PATCH v2 00/23] switch sockets+chardev to QemuOpts Gerd Hoffmann
2009-09-10  8:58 ` [Qemu-devel] [PATCH v2 01/23] QemuOpts: split option parser into two functions Gerd Hoffmann
2009-09-10  8:58 ` [Qemu-devel] [PATCH v2 02/23] qemu-option.h include protectors Gerd Hoffmann
2009-09-10  8:58 ` [Qemu-devel] [PATCH v2 03/23] switch chardev to QemuOpts: infrastructure, null device Gerd Hoffmann
2009-09-10  8:58 ` [Qemu-devel] [PATCH v2 04/23] convert file+pipe chardevs to QemuOpts Gerd Hoffmann
2009-09-10  8:58 ` [Qemu-devel] [PATCH v2 05/23] sockets: add unix_connect_opts Gerd Hoffmann
2009-09-10  8:58 ` [Qemu-devel] [PATCH v2 06/23] sockets: add unix_listen_opts Gerd Hoffmann
2009-09-10  8:58 ` [Qemu-devel] [PATCH v2 07/23] sockets: add unix_*_opts for windows Gerd Hoffmann
2009-09-10  8:58 ` [Qemu-devel] [PATCH v2 08/23] sockets: add inet_connect_opts Gerd Hoffmann
2009-09-10  8:58 ` [Qemu-devel] [PATCH v2 09/23] sockets: add inet_listen_opts Gerd Hoffmann
2009-09-10  8:58 ` [Qemu-devel] [PATCH v2 10/23] convert unix+tcp chardevs to QemuOpts Gerd Hoffmann
2009-09-10  8:58 ` Gerd Hoffmann [this message]
2009-09-10  8:58 ` [Qemu-devel] [PATCH v2 12/23] convert stdio chardev " Gerd Hoffmann
2009-09-10  8:58 ` [Qemu-devel] [PATCH v2 13/23] convert msmouse " Gerd Hoffmann
2009-09-10  8:58 ` [Qemu-devel] [PATCH v2 14/23] convert braille " Gerd Hoffmann
2009-09-10  8:58 ` [Qemu-devel] [PATCH v2 15/23] convert windows console " Gerd Hoffmann
2009-09-10  8:58 ` [Qemu-devel] [PATCH v2 16/23] convert tty + parport chardevs " Gerd Hoffmann
2009-09-10  8:58 ` [Qemu-devel] [PATCH v2 17/23] convert vc chardev " Gerd Hoffmann
2009-09-10  8:58 ` [Qemu-devel] [PATCH v2 18/23] convert mux " Gerd Hoffmann
2009-09-10  8:58 ` [Qemu-devel] [PATCH v2 19/23] convert udp " Gerd Hoffmann
2009-09-10  8:58 ` [Qemu-devel] [PATCH v2 20/23] Allow -serial chardev:<name> Gerd Hoffmann
2009-09-10  8:58 ` [Qemu-devel] [PATCH v2 21/23] qdev: add parser for chardev properties Gerd Hoffmann
2009-09-10  8:58 ` [Qemu-devel] [PATCH v2 22/23] monitor: fix muxing Gerd Hoffmann
2009-09-10  8:58 ` [Qemu-devel] [PATCH v2 23/23] move mux focus field from CharDriverState to MuxDriver Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1252573135-27688-12-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).