qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Mark McLoughlin <markmc@redhat.com>
To: qemu-devel@nongnu.org
Cc: Mark McLoughlin <markmc@redhat.com>
Subject: [Qemu-devel] [PATCH 03/19] Remove double error message in qemu_option_set()
Date: Thu, 10 Sep 2009 16:18:45 +0100	[thread overview]
Message-ID: <1252595941-15196-4-git-send-email-markmc@redhat.com> (raw)
In-Reply-To: <1252595941-15196-1-git-send-email-markmc@redhat.com>

qemu_opt_set() prints an error message in all failure cases, so
qemu_set_option() doesn't need to print another error.

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
---
 qemu-config.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/qemu-config.c b/qemu-config.c
index 61e6ed1..733cc24 100644
--- a/qemu-config.c
+++ b/qemu-config.c
@@ -186,11 +186,9 @@ int qemu_set_option(const char *str)
         return -1;
     }
 
-    if (qemu_opt_set(opts, arg, str+offset+1) == -1) {
-        fprintf(stderr, "failed to set \"%s\" for %s \"%s\"\n",
-                arg, lists[i]->name, id);
+    if (qemu_opt_set(opts, arg, str+offset+1) == -1)
         return -1;
-    }
+
     return 0;
 }
 
-- 
1.6.2.5

  parent reply	other threads:[~2009-09-10 15:26 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-10 15:18 [Qemu-devel] [PATCH 00/19] Port -net to QemuOpts Mark McLoughlin
2009-09-10 15:18 ` [Qemu-devel] [PATCH 01/19] Suppress more more kraxelisms Mark McLoughlin
2009-09-10 18:02   ` Michael S. Tsirkin
2009-09-10 15:18 ` [Qemu-devel] [PATCH 02/19] Remove bogus error message from qemu_opts_set() Mark McLoughlin
2009-09-10 18:01   ` Michael S. Tsirkin
2009-09-10 15:18 ` Mark McLoughlin [this message]
2009-09-10 18:03   ` [Qemu-devel] [PATCH 03/19] Remove double error message in qemu_option_set() Michael S. Tsirkin
2009-09-10 18:36     ` braces [was Re: [Qemu-devel] [PATCH 03/19] Remove double error message in qemu_option_set()] Mark McLoughlin
2009-09-11  5:01       ` Michael S. Tsirkin
2009-09-11  5:50       ` Amit Shah
2009-09-10 15:18 ` [Qemu-devel] [PATCH 04/19] Remove double error message for -device option parsing Mark McLoughlin
     [not found]   ` <m38wgmhin3.fsf@neno.mitica>
2009-09-10 18:10     ` [Qemu-devel] " Mark McLoughlin
2009-09-10 15:18 ` [Qemu-devel] [PATCH 05/19] Make qemu_opts_parse() handle empty strings Mark McLoughlin
2009-09-10 15:18 ` [Qemu-devel] [PATCH 06/19] Add qemu_opts_validate() for post parsing validation Mark McLoughlin
2009-09-11  7:47   ` Gerd Hoffmann
2009-09-11 12:38     ` Mark McLoughlin
2009-09-11 13:51       ` Gerd Hoffmann
2009-09-10 15:18 ` [Qemu-devel] [PATCH 07/19] Never overwrite a QemuOpt Mark McLoughlin
2009-09-11  7:51   ` Gerd Hoffmann
2009-09-10 15:18 ` [Qemu-devel] [PATCH 08/19] Add qemu_net_opts Mark McLoughlin
2009-09-10 15:18 ` [Qemu-devel] [PATCH 09/19] Port -net none and -net nic to QemuOpts Mark McLoughlin
2009-09-11  7:57   ` Gerd Hoffmann
2009-09-11 12:39     ` Mark McLoughlin
2009-09-10 15:18 ` [Qemu-devel] [PATCH 10/19] Port -net user " Mark McLoughlin
2009-09-10 15:18 ` [Qemu-devel] [PATCH 11/19] Port -net tap " Mark McLoughlin
2009-09-10 15:18 ` [Qemu-devel] [PATCH 12/19] Port -net socket " Mark McLoughlin
2009-09-10 15:18 ` [Qemu-devel] [PATCH 13/19] Port -net vde " Mark McLoughlin
2009-09-10 15:18 ` [Qemu-devel] [PATCH 14/19] Port -net dump " Mark McLoughlin
2009-09-10 15:18 ` [Qemu-devel] [PATCH 15/19] Clean up legacy code in net_client_init() Mark McLoughlin
2009-09-10 15:18 ` [Qemu-devel] [PATCH 16/19] Port host_net_add monitor command to QemuOpts Mark McLoughlin
2009-09-10 15:18 ` [Qemu-devel] [PATCH 17/19] Port usb net " Mark McLoughlin
2009-09-10 15:19 ` [Qemu-devel] [PATCH 18/19] Port PCI NIC hotplug " Mark McLoughlin
2009-09-10 15:19 ` [Qemu-devel] [PATCH 19/19] Final net cleanup after conversion " Mark McLoughlin
2009-09-18 12:08 ` [Qemu-devel] [PATCH 00/19] Port -net " Mark McLoughlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1252595941-15196-4-git-send-email-markmc@redhat.com \
    --to=markmc@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).