From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MllXx-0006GQ-Vy for qemu-devel@nongnu.org; Thu, 10 Sep 2009 11:26:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MllXs-0006Ch-16 for qemu-devel@nongnu.org; Thu, 10 Sep 2009 11:26:52 -0400 Received: from [199.232.76.173] (port=40177 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MllXr-0006Ca-RV for qemu-devel@nongnu.org; Thu, 10 Sep 2009 11:26:47 -0400 Received: from mail25.svc.cra.dublin.eircom.net ([159.134.118.54]:45356) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1MllXq-00007C-2e for qemu-devel@nongnu.org; Thu, 10 Sep 2009 11:26:46 -0400 From: Mark McLoughlin Date: Thu, 10 Sep 2009 16:18:45 +0100 Message-Id: <1252595941-15196-4-git-send-email-markmc@redhat.com> In-Reply-To: <1252595941-15196-1-git-send-email-markmc@redhat.com> References: <1252595941-15196-1-git-send-email-markmc@redhat.com> Subject: [Qemu-devel] [PATCH 03/19] Remove double error message in qemu_option_set() List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Mark McLoughlin qemu_opt_set() prints an error message in all failure cases, so qemu_set_option() doesn't need to print another error. Signed-off-by: Mark McLoughlin --- qemu-config.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/qemu-config.c b/qemu-config.c index 61e6ed1..733cc24 100644 --- a/qemu-config.c +++ b/qemu-config.c @@ -186,11 +186,9 @@ int qemu_set_option(const char *str) return -1; } - if (qemu_opt_set(opts, arg, str+offset+1) == -1) { - fprintf(stderr, "failed to set \"%s\" for %s \"%s\"\n", - arg, lists[i]->name, id); + if (qemu_opt_set(opts, arg, str+offset+1) == -1) return -1; - } + return 0; } -- 1.6.2.5