From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MllXx-0006GC-Km for qemu-devel@nongnu.org; Thu, 10 Sep 2009 11:26:53 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MllXr-0006CH-Co for qemu-devel@nongnu.org; Thu, 10 Sep 2009 11:26:51 -0400 Received: from [199.232.76.173] (port=40176 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MllXr-0006C4-1o for qemu-devel@nongnu.org; Thu, 10 Sep 2009 11:26:47 -0400 Received: from mail21.svc.cra.dublin.eircom.net ([159.134.118.222]:44941) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1MllXq-00007J-32 for qemu-devel@nongnu.org; Thu, 10 Sep 2009 11:26:46 -0400 From: Mark McLoughlin Date: Thu, 10 Sep 2009 16:18:46 +0100 Message-Id: <1252595941-15196-5-git-send-email-markmc@redhat.com> In-Reply-To: <1252595941-15196-1-git-send-email-markmc@redhat.com> References: <1252595941-15196-1-git-send-email-markmc@redhat.com> Subject: [Qemu-devel] [PATCH 04/19] Remove double error message for -device option parsing List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Mark McLoughlin qemu_opts_parse() gives a suitable error message in all failure cases so we can remove the error message from the caller. Signed-off-by: Mark McLoughlin --- vl.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/vl.c b/vl.c index 6da83a6..ed07d50 100644 --- a/vl.c +++ b/vl.c @@ -5251,11 +5251,8 @@ int main(int argc, char **argv, char **envp) add_device_config(DEV_USB, optarg); break; case QEMU_OPTION_device: - opts = qemu_opts_parse(&qemu_device_opts, optarg, "driver"); - if (!opts) { - fprintf(stderr, "parse error: %s\n", optarg); + if (!qemu_opts_parse(&qemu_device_opts, optarg, "driver")) exit(1); - } break; case QEMU_OPTION_smp: smp_parse(optarg); -- 1.6.2.5