Re: [Qemu-devel] [PATCH] [RESEND2] Qemu unmaintained?

[Mark McLoughlin <markmc@redhat.com>]

On Thu, 2009-09-10 at 19:35 +0300, Avi Kivity wrote:

> Unfairly picking on Mark (who usually writes truly excellent changelogs, 
> but this one is such a gem):
> 
> > Subject: [Qemu-devel] [PATCH 01/19] Suppress more more kraxelism
> >
> > Let's kick off this series with some of the more critical fixes.
> >
> > Signed-off-by: Mark McLoughlin<markmc@redhat.com>
> >    
> 
> What would you be thinking hunting the commit log for some change and 
> coming up with this?
> 
> (Mark, apologies for picking on you, it's truly unfair of me, but I 
> can't help it)

As you say, I normally try very hard with my changelogs, but I don't
think the odd joke hurts much.

Look back over the changelog to a similar, but even more concise commit
message, a couple of weeks back that didn't go through Anthony. I was
parodying that one :-)

Anyway, you've cc-ed me now, so IMHO:

  - If one is so inclined, improving a commit message before pushing is 
    perfectly fine

  - A simple "Applied, thanks" would be hugely appreciated

  - This "apply everything, test at length, reject problematic patches" 
    appears to lead to a very batchy patch flow; there's a trade off to 
    be made between trying to catch every regression before it hits the
    tree and the delay that effort introduces before the tree gets more
    widely tested by others

Cheers,
Mark.