From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mm5Qf-0003lS-Ik
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 08:40:41 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mm5QY-0003gM-3q
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 08:40:39 -0400
Received: from [199.232.76.173] (port=51502 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mm5QW-0003g9-5W
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 08:40:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60844)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <markmc@redhat.com>) id 1Mm5QV-0005I2-N7
	for qemu-devel@nongnu.org; Fri, 11 Sep 2009 08:40:31 -0400
Received: from int-mx05.intmail.prod.int.phx2.redhat.com
	(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8BCeU5d019209
	for <qemu-devel@nongnu.org>; Fri, 11 Sep 2009 08:40:31 -0400
Subject: Re: [Qemu-devel] [PATCH 09/19] Port -net none and -net nic to QemuOpts
From: Mark McLoughlin <markmc@redhat.com>
In-Reply-To: <4AAA02E1.1040703@redhat.com>
References: <1252595941-15196-1-git-send-email-markmc@redhat.com>
	<1252595941-15196-10-git-send-email-markmc@redhat.com>
	<4AAA02E1.1040703@redhat.com>
Content-Type: text/plain
Date: Fri, 11 Sep 2009 13:39:24 +0100
Message-Id: <1252672764.20624.40.camel@blaa>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Reply-To: Mark McLoughlin <markmc@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On Fri, 2009-09-11 at 09:57 +0200, Gerd Hoffmann wrote:
> Hi,
> 
> > +#define NET_COMMON_PARAMS_DESC                     \
> 
> > +        .name = "name",                            \
> > +        .type = QEMU_OPT_STRING,                   \
> > +        .help = "identifier for monitor commands", \
> 
> QemuOpts has id= which IMHO should be used here instead for consistency 
> reasons.  I suspect we have to support name= as well for backward 
> compatibility ...

Yes, libvirt uses name= already

Cheers,
Mark.