qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] fill in fd information in usb device
@ 2009-09-17 22:40 Glauber Costa
  0 siblings, 0 replies; only message in thread
From: Glauber Costa @ 2009-09-17 22:40 UTC (permalink / raw)
  To: qemu-devel; +Cc: aliguori

We currently open the usb device and store the file descriptor at
fd. But we don't touch the dev structure. Further on,
usb_host_claim_interfaces() issues ioctls on dev->fd, which will obviously
fail

This line used to be there in the past, but was probably removed by accident
somewhere back in history.

Signed-off-by: Glauber Costa <glommer@redhat.com>
---
 usb-linux.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/usb-linux.c b/usb-linux.c
index c434e4f..01d891c 100644
--- a/usb-linux.c
+++ b/usb-linux.c
@@ -922,6 +922,7 @@ static USBDevice *usb_host_device_open_addr(int bus_num, int addr, const char *p
 
     dev->bus_num = bus_num;
     dev->addr = addr;
+    dev->fd = fd;
 
     /* read the device description */
     dev->descr_len = read(fd, dev->descr, sizeof(dev->descr));
-- 
1.6.2.2

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2009-09-17 22:14 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-17 22:40 [Qemu-devel] [PATCH] fill in fd information in usb device Glauber Costa

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).