From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mq3hV-0007vp-RU
	for qemu-devel@nongnu.org; Tue, 22 Sep 2009 07:38:30 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mq3hP-0007ul-EJ
	for qemu-devel@nongnu.org; Tue, 22 Sep 2009 07:38:27 -0400
Received: from [199.232.76.173] (port=53828 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mq3hO-0007ue-MK
	for qemu-devel@nongnu.org; Tue, 22 Sep 2009 07:38:23 -0400
Received: from mx1.redhat.com ([209.132.183.28]:28239)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <markmc@redhat.com>) id 1Mq3hO-0007XI-81
	for qemu-devel@nongnu.org; Tue, 22 Sep 2009 07:38:22 -0400
Subject: Re: [Qemu-devel] [PATCH] Drop config_error(), use qemu_error() instead
From: Mark McLoughlin <markmc@redhat.com>
In-Reply-To: <87hbv96q4d.fsf@pike.pond.sub.org>
References: <87hbv96q4d.fsf@pike.pond.sub.org>
Content-Type: text/plain
Date: Tue, 22 Sep 2009 12:37:02 +0100
Message-Id: <1253619422.6528.5.camel@blaa>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Reply-To: Mark McLoughlin <markmc@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Jan Kiszka <jan.kiszka@web.de>, qemu-devel@nongnu.org

On Sat, 2009-09-12 at 01:03 +0200, Markus Armbruster wrote:

> There's one user-visible difference: config_error() prepended "qemu: "
> to a message bound for stderr.  qemu_error() doesn't, which means the
> prefix goes away with this commit.
...
> ---
>  net.c |  128 ++++++++++++++++++++++++++++-------------------------------------
>  1 files changed, 55 insertions(+), 73 deletions(-)
> 
> diff --git a/net.c b/net.c
> index 4510694..e88919b 100644
> --- a/net.c
> +++ b/net.c
> @@ -641,21 +641,6 @@ qemu_sendv_packet(VLANClientState *vc, const struct iovec *iov, int iovcnt)
>      return qemu_sendv_packet_async(vc, iov, iovcnt, NULL);
>  }
>  
> -static void config_error(Monitor *mon, const char *fmt, ...)
> -{
> -    va_list ap;
> -
> -    va_start(ap, fmt);
> -    if (mon) {
> -        monitor_vprintf(mon, fmt, ap);
> -    } else {
> -        fprintf(stderr, "qemu: ");
> -        vfprintf(stderr, fmt, ap);
> -        exit(1);

There's another difference, actually - qemu_error() doesn't abort when
printing an error to stderr

I'm fine with that, but could you check all callers to make sure that's
sane?

Thanks,
Mark.