From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MqP2s-0003n0-FP for qemu-devel@nongnu.org; Wed, 23 Sep 2009 06:25:58 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MqP2h-0003gJ-Hw for qemu-devel@nongnu.org; Wed, 23 Sep 2009 06:25:52 -0400 Received: from [199.232.76.173] (port=37814 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MqP2g-0003fn-Kb for qemu-devel@nongnu.org; Wed, 23 Sep 2009 06:25:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12882) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MqP2f-0001V1-Gh for qemu-devel@nongnu.org; Wed, 23 Sep 2009 06:25:45 -0400 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8NAPiO8028199 for ; Wed, 23 Sep 2009 06:25:44 -0400 From: Mark McLoughlin Date: Wed, 23 Sep 2009 11:24:06 +0100 Message-Id: <1253701463-3134-8-git-send-email-markmc@redhat.com> In-Reply-To: <1253701463-3134-1-git-send-email-markmc@redhat.com> References: <1253701463-3134-1-git-send-email-markmc@redhat.com> Subject: [Qemu-devel] [PATCH 07/24] Remove bogus error message from qemu_opts_set() List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Mark McLoughlin The only way qemu_opts_create() can fail is if a QemuOpts with that id already exists and fail_if_exists=1. In that case, we already print an error which makes more sense than the one in qemu_opts_set(). Signed-off-by: Mark McLoughlin --- qemu-option.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index 9fe1f95..246f211 100644 --- a/qemu-option.c +++ b/qemu-option.c @@ -670,8 +670,6 @@ int qemu_opts_set(QemuOptsList *list, const char *id, opts = qemu_opts_create(list, id, 1); if (opts == NULL) { - fprintf(stderr, "id \"%s\" not found for \"%s\"\n", - id, list->name); return -1; } return qemu_opt_set(opts, name, value); -- 1.6.2.5