From: Mark McLoughlin <markmc@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Fix exit on 'pci_add' Monitor command
Date: Thu, 24 Sep 2009 21:07:04 +0100 [thread overview]
Message-ID: <1253822824.32256.55.camel@blaa> (raw)
In-Reply-To: <87iqf8ciup.fsf@pike.pond.sub.org>
On Thu, 2009-09-24 at 20:12 +0200, Markus Armbruster wrote:
> My major complaint is that I'd rather see the code cleaned up there.
> It's perfectly fine for code that can run only during startup to
> terminate the program on configuration error. Code to be used after
> startup (used from monitor, in particular) must not do that. Instead,
> it should return failure up the call chain, until we reach either
> startup code or monitor code, where the policy how to handle the error
> resides.
Agree, I'd like to see it cleaned up.
However, Luiz's patch fixes the most serious side effect without a major
re-factoring, so I'd like to see that go in first (and stable-0.11) and
do the re-factoring later.
Cheers,
Mark.
next prev parent reply other threads:[~2009-09-24 20:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-24 14:16 [Qemu-devel] [PATCH] Fix exit on 'pci_add' Monitor command Luiz Capitulino
2009-09-24 18:12 ` Markus Armbruster
2009-09-24 19:31 ` Luiz Capitulino
2009-09-25 1:50 ` Markus Armbruster
2009-09-24 20:07 ` Mark McLoughlin [this message]
2009-09-25 1:51 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253822824.32256.55.camel@blaa \
--to=markmc@redhat.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).