From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mr9x5-0000AH-Oa for qemu-devel@nongnu.org; Fri, 25 Sep 2009 08:31:07 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mr9wy-00007q-DS for qemu-devel@nongnu.org; Fri, 25 Sep 2009 08:31:05 -0400 Received: from [199.232.76.173] (port=46013 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mr9wy-00007Y-2Q for qemu-devel@nongnu.org; Fri, 25 Sep 2009 08:31:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17640) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mr9wx-0000IG-M2 for qemu-devel@nongnu.org; Fri, 25 Sep 2009 08:30:59 -0400 From: Glauber Costa Date: Fri, 25 Sep 2009 08:30:57 -0400 Message-Id: <1253881857-4256-1-git-send-email-glommer@redhat.com> Subject: [Qemu-devel] [PATCH] fix use after free List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com We are using the vs structure when it was just freed. Classic use after free, fix it. Signed-off-by: Glauber Costa --- vnc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vnc.c b/vnc.c index 5eaef6a..592c9b3 100644 --- a/vnc.c +++ b/vnc.c @@ -918,8 +918,8 @@ static void vnc_disconnect_finish(VncState *vs) if (!vs->vd->clients) dcl->idle = 1; - qemu_free(vs); vnc_remove_timer(vs->vd); + qemu_free(vs); } int vnc_client_io_error(VncState *vs, int ret, int last_errno) -- 1.6.2.2