From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MsIvi-000567-DS
	for qemu-devel@nongnu.org; Mon, 28 Sep 2009 12:18:26 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MsIvd-00054C-R5
	for qemu-devel@nongnu.org; Mon, 28 Sep 2009 12:18:25 -0400
Received: from [199.232.76.173] (port=47291 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MsIvd-000549-Kr
	for qemu-devel@nongnu.org; Mon, 28 Sep 2009 12:18:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37407)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <markmc@redhat.com>) id 1MsIvd-0004nL-8C
	for qemu-devel@nongnu.org; Mon, 28 Sep 2009 12:18:21 -0400
Received: from int-mx03.intmail.prod.int.phx2.redhat.com
	(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8SGIKX6021305
	for <qemu-devel@nongnu.org>; Mon, 28 Sep 2009 12:18:20 -0400
Subject: Re: [Qemu-devel] [PATCH 0/6] Fix pci_add not to exit on error &
	other fixes
From: Mark McLoughlin <markmc@redhat.com>
In-Reply-To: <1254153903.2802.3796.camel@blaa>
References: <cover.1253843232.git.armbru@redhat.com>
	<1254153903.2802.3796.camel@blaa>
Content-Type: text/plain
Date: Mon, 28 Sep 2009 17:16:53 +0100
Message-Id: <1254154613.2802.3800.camel@blaa>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Reply-To: Mark McLoughlin <markmc@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

On Mon, 2009-09-28 at 17:05 +0100, Mark McLoughlin wrote:
> On Fri, 2009-09-25 at 03:53 +0200, Markus Armbruster wrote:
> > Markus Armbruster (6):
> >   Fix pci_vga_init() not to ignore bus argument
> >   Fix pci_add storage not to exit on bad first argument
> >   Make it obvious that pci_nic_init() can't fail
> >   Fix pci_add nic not to exit on bad model
> >   pci_create() is now unused, remove it
> >   Rename pci_create_noinit() to pci_create()
> 
> Looks like a good series to me too
> 
> Acked-by: Mark McLoughlin <markmc@redhat.com>

Oh, and IMHO, at least patches 3 and 4 makes sense for stable-0.11;
patch 4 just needs an update for e1000 being the default model now

Patch 2 might make sense too with a little massaging

Cheers,
Mark.