Re: [Qemu-devel] [RfC PATCH 0/3] qdev-ify network cards

[Mark McLoughlin <markmc@redhat.com>]

On Fri, 2009-09-25 at 21:43 +0200, Gerd Hoffmann wrote:
> Hi,
> 
> Short RfC patch series to get the discussion rolling.  We really need to
> get the nic drivers qdev-ified properly, so qemu stops segfaulting on
> '-device $any_nic_here'.
> 
> To keep things small simple I've started with the ne2k_isa.  All the PCI
> nics share the initialization path and thus I can't simply pick a single
> one as example and convert it.
> 
> The network card can now be created using ...
> 
>   -device ne2k_isa,mac=00:11:22:33:44:55,vlan=0,irq=3,id=foo
> 
> 'info qtree' shows ...
> 
> 	[ ... ]
>         bus: isa.0
>           type ISA
>           dev: ne2k_isa, id "foo"
>             dev-prop: iobase = 0x300
>             dev-prop: irq = 3
>             dev-prop: vlan = 1
>             dev-prop: mac = 00:11:22:33:44:55
> 	[ ... ]
> 
> 'info network' shows:
> 
> 	[ ... ]
> 	VLAN 1 devices:
> 	  foo: model=ne2k_isa,macaddr=00:11:22:33:44:55
> 
> The nic initialization code calls qemu_new_vlan_client() with the
> vlan specified using the vlan property.

One thing I'd like to see is that if vlan= isn't specified, the nic
shouldn't be connected to any vlan.

I want to add the option to connect a nic directly to a backend without
any vlan involved. That implies you should be able to create a
disconnected nic and later connect it to a backend. Assuming vlan=0
where none is specified makes that difficult.

Patches look fine otherwise.

Cheers,
Mark.