From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MstVp-0007F8-Cu
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 03:22:09 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MstVk-0007Ew-VF
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 03:22:08 -0400
Received: from [199.232.76.173] (port=57249 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MstVk-0007Et-QU
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 03:22:04 -0400
Received: from mx20.gnu.org ([199.232.41.8]:15623)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <markmc@redhat.com>) id 1MstVk-00060K-0Z
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 03:22:04 -0400
Received: from mx1.redhat.com ([209.132.183.28])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <markmc@redhat.com>) id 1MstVi-0005CO-GF
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 03:22:02 -0400
Received: from int-mx03.intmail.prod.int.phx2.redhat.com
	(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8U7M005020413
	for <qemu-devel@nongnu.org>; Wed, 30 Sep 2009 03:22:00 -0400
Subject: Re: [Qemu-devel] [RfC PATCH 0/3] qdev-ify network cards
From: Mark McLoughlin <markmc@redhat.com>
In-Reply-To: <1253907783-1231-1-git-send-email-kraxel@redhat.com>
References: <1253907783-1231-1-git-send-email-kraxel@redhat.com>
Content-Type: text/plain
Date: Wed, 30 Sep 2009 08:20:30 +0100
Message-Id: <1254295230.3105.12.camel@blaa>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Reply-To: Mark McLoughlin <markmc@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On Fri, 2009-09-25 at 21:43 +0200, Gerd Hoffmann wrote:
> Hi,
> 
> Short RfC patch series to get the discussion rolling.  We really need to
> get the nic drivers qdev-ified properly, so qemu stops segfaulting on
> '-device $any_nic_here'.
> 
> To keep things small simple I've started with the ne2k_isa.  All the PCI
> nics share the initialization path and thus I can't simply pick a single
> one as example and convert it.
> 
> The network card can now be created using ...
> 
>   -device ne2k_isa,mac=00:11:22:33:44:55,vlan=0,irq=3,id=foo
> 
> 'info qtree' shows ...
> 
> 	[ ... ]
>         bus: isa.0
>           type ISA
>           dev: ne2k_isa, id "foo"
>             dev-prop: iobase = 0x300
>             dev-prop: irq = 3
>             dev-prop: vlan = 1
>             dev-prop: mac = 00:11:22:33:44:55
> 	[ ... ]
> 
> 'info network' shows:
> 
> 	[ ... ]
> 	VLAN 1 devices:
> 	  foo: model=ne2k_isa,macaddr=00:11:22:33:44:55
> 
> The nic initialization code calls qemu_new_vlan_client() with the
> vlan specified using the vlan property.

One thing I'd like to see is that if vlan= isn't specified, the nic
shouldn't be connected to any vlan.

I want to add the option to connect a nic directly to a backend without
any vlan involved. That implies you should be able to create a
disconnected nic and later connect it to a backend. Assuming vlan=0
where none is specified makes that difficult.

Patches look fine otherwise.

Cheers,
Mark.