From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MsuGr-0004yX-89
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 04:10:45 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MsuGm-0004wp-9Y
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 04:10:44 -0400
Received: from [199.232.76.173] (port=53412 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MsuGm-0004wk-2w
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 04:10:40 -0400
Received: from smarthost.c4l.co.uk ([82.197.83.77]:58722)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <nathan@parenthephobia.org.uk>)
	id 1MsuGl-00020u-OY
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 04:10:39 -0400
Subject: Re: [Qemu-devel] [PATCH 4/6] virtio-console-port: Add a new device
	on	the virtio-console-bus for generic host-guest communication
From: Nathan Baum <nathan@parenthephobia.org.uk>
In-Reply-To: <4AC24D31.2070709@redhat.com>
References: <1254225888-17093-1-git-send-email-amit.shah@redhat.com>
	<1254225888-17093-2-git-send-email-amit.shah@redhat.com>
	<1254225888-17093-3-git-send-email-amit.shah@redhat.com>
	<1254225888-17093-4-git-send-email-amit.shah@redhat.com>
	<1254225888-17093-5-git-send-email-amit.shah@redhat.com>
	<4AC24D31.2070709@redhat.com>
Content-Type: text/plain
Date: Wed, 30 Sep 2009 09:09:40 +0100
Message-Id: <1254298180.1766.0.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>, qemu-devel@nongnu.org

On Tue, 2009-09-29 at 20:08 +0200, Gerd Hoffmann wrote:
> > +typedef struct VirtIOConsole
> > +{
> > +    VirtConPort port;
> 
> Your CharDriverState should go here.
> 
> > +        DEFINE_PROP_INT32("flush_buffers", VirtConPort, flush_buffers, 0),
> 
> Well, we should find a better name for that one.  flush_buffers is very 
> unclear.  It actually is dont_cache_data_when_unconnected.  That name is 
> insane long though.

volatile_when_unconnected?