[Qemu-devel] [PATCH 0/3] Clean up error handling in net.c

[Qemu-devel] [PATCH 0/3] Clean up error handling in net.c

[Markus Armbruster]

Caveat: I'm not familiar with slirp, and I'm not sure 1/3 is the right
thing to do.

Markus Armbruster (3):
  Make net_client_init() consume slirp_configs even on error
  Don't exit() in config_error()
  Drop config_error(), use qemu_error() instead

 net.c |  192 ++++++++++++++++++++++++++++++++---------------------------------
 net.h |    4 +-
 vl.c  |    9 ++-
 3 files changed, 102 insertions(+), 103 deletions(-)

Re: [Qemu-devel] [PATCH 0/3] Clean up error handling in net.c

[Luiz Capitulino]

On Mon, 28 Sep 2009 21:11:32 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Caveat: I'm not familiar with slirp, and I'm not sure 1/3 is the right
> thing to do.

 FWIW, I'm working on a infrastructure for error handling in the Monitor.

 The goal is not only to fix abort/don't abort cases, but also to pass
error information up in the call stack, so that the protocol can emit it.

 So, in case you are planning to fix more of those abort cases, I would
really appreciate if you do this as part of a QObject conversion,
otherwise I would have to re-visit the handler to do the conversion
myself.

 I should post patches this week, although I'm not sure if I've picked
up the best API design for this...

Re: [Qemu-devel] [PATCH 0/3] Clean up error handling in net.c

[Markus Armbruster]

Luiz Capitulino <lcapitulino@redhat.com> writes:

> On Mon, 28 Sep 2009 21:11:32 +0200
> Markus Armbruster <armbru@redhat.com> wrote:
>
>> Caveat: I'm not familiar with slirp, and I'm not sure 1/3 is the right
>> thing to do.
>
>  FWIW, I'm working on a infrastructure for error handling in the Monitor.
>
>  The goal is not only to fix abort/don't abort cases, but also to pass
> error information up in the call stack, so that the protocol can emit it.
>
>  So, in case you are planning to fix more of those abort cases, I would
> really appreciate if you do this as part of a QObject conversion,
> otherwise I would have to re-visit the handler to do the conversion
> myself.

Understood.

This time around, I didn't get close to the handler.  I just fixed
low-level code called from both startup and monitor.

>  I should post patches this week, although I'm not sure if I've picked
> up the best API design for this...

Yes, show us the code :)

Re: [Qemu-devel] [PATCH 0/3] Clean up error handling in net.c

[Mark McLoughlin]

On Mon, 2009-09-28 at 21:11 +0200, Markus Armbruster wrote:
> Caveat: I'm not familiar with slirp, and I'm not sure 1/3 is the right
> thing to do.
> 
> Markus Armbruster (3):
>   Make net_client_init() consume slirp_configs even on error
>   Don't exit() in config_error()
>   Drop config_error(), use qemu_error() instead

The series looks good to me

Since it conflicts significantly with my conversion of -net to QemuOpts,
I've pulled them into my tree (modulo the spurious USB change) and
re-based:

  http://git.et.redhat.com/?p=qemu-net.git

Hope you agree that makes sense

Thanks,
Mark.