From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mszjr-0006HI-MQ
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 10:01:03 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mszjn-0006BG-2L
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 10:01:03 -0400
Received: from [199.232.76.173] (port=43654 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mszjm-0006B5-UK
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 10:00:58 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38083)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <markmc@redhat.com>) id 1Mszjm-0007HY-Br
	for qemu-devel@nongnu.org; Wed, 30 Sep 2009 10:00:58 -0400
From: Mark McLoughlin <markmc@redhat.com>
In-Reply-To: <4AC36355.8040908@redhat.com>
References: <1241459088.26045.1.camel@lappy>
	<1241513785-28738-1-git-send-email-markmc@redhat.com>
	<1254257151.29022.11.camel@blaa> <20090930135144.GA29956@infradead.org>
	<4AC36355.8040908@redhat.com>
Content-Type: text/plain
Date: Wed, 30 Sep 2009 14:59:20 +0100
Message-Id: <1254319160.3105.67.camel@blaa>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO
 code removed upstream
Reply-To: Mark McLoughlin <markmc@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>, qemu-devel@nongnu.org, kvm@vger.kernel.org

On Wed, 2009-09-30 at 15:55 +0200, Avi Kivity wrote:
> On 09/30/2009 03:51 PM, Christoph Hellwig wrote:
> > I might sound like a broken record, but why isn't the full GSO support
> > for virtio-net upstream in qemu?
> >    
> 
> IIRC the current hacks are not upstream quality.
> 
> The problem (again IIRC) is that the guest and host negotiate a 
> protocol, but the qemu vlan model doesn't have a guest and a host, it 
> has peers (possibly more than two), so a lot of translation has to take 
> place if you have one peer supporting a guest feature and another not.

Right.

> IMO the best way out is to drop the vlan model.  It has its uses, but 
> they can all be implemented in other ways, and are all have minor usage 
> compared to the business of getting data into and out of a guest.

I think we should keep the vlan stuff, just de-emphasise it.

I'm planning on adding -hostnet and -nic arguments, which would not use
vlans by default but rather connect the nic directly to the host side.

The QemuOpts conversion of -net which is waiting to be merged is the
first stage of that.

Cheers,
Mark.