From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MtFPP-0005Nz-CC
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 02:44:59 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MtFPK-0005MC-QE
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 02:44:58 -0400
Received: from [199.232.76.173] (port=54405 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MtFPK-0005Lx-C8
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 02:44:54 -0400
Received: from mx20.gnu.org ([199.232.41.8]:24380)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <markmc@redhat.com>) id 1MtFPJ-0002V3-Ma
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 02:44:53 -0400
Received: from mx1.redhat.com ([209.132.183.28])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <markmc@redhat.com>) id 1MtFPI-0003Nq-Ru
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 02:44:53 -0400
Subject: Re: [Qemu-devel] [PATCH 16/24] Port -net tap to QemuOpts
From: Mark McLoughlin <markmc@redhat.com>
In-Reply-To: <4AC3B480.2050709@codemonkey.ws>
References: <1253701463-3134-1-git-send-email-markmc@redhat.com>
	<1253701463-3134-17-git-send-email-markmc@redhat.com>
	<4AC3B480.2050709@codemonkey.ws>
Content-Type: text/plain
Date: Thu, 01 Oct 2009 07:43:19 +0100
Message-Id: <1254379399.2920.16.camel@blaa>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Reply-To: Mark McLoughlin <markmc@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

On Wed, 2009-09-30 at 14:41 -0500, Anthony Liguori wrote:
> Mark McLoughlin wrote:
> > -static void tap_set_sndbuf(TAPState *s, const char *sndbuf_str, Monitor *mon)
> > +static void tap_set_sndbuf(TAPState *s, QemuOpts *opts, Monitor *mon)
> >  {
> >      if (sndbuf_str) {
> >          config_error(mon, "No '-net tap,sndbuf=<nbytes>' support available\n");
> > @@ -2546,6 +2543,92 @@ static int net_init_slirp(QemuOpts *opts, Monitor *mon)
> >      return ret;
> >  }
> >   
> Breaks the build.

Yes, on older linux hosts.

Fixed in my tree now; the check isn't needed at all because the sndbuf
QemuOpt isn't defined if TUNSETSNDBUF isn't defined

Cheers,
Mark.