From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MtOIa-00072Q-Bu
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 12:14:32 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MtOIV-0006vq-Lo
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 12:14:31 -0400
Received: from [199.232.76.173] (port=44679 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MtOIV-0006vU-Dv
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 12:14:27 -0400
Received: from mx1.redhat.com ([209.132.183.28]:4454)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <markmc@redhat.com>) id 1MtOIV-0006gI-Dp
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 12:14:27 -0400
Subject: Re: [Qemu-devel] [PATCH] Improve error reporting on file access
From: Mark McLoughlin <markmc@redhat.com>
In-Reply-To: <20091001144256.GA30845@linuxtx.org>
References: <20091001144256.GA30845@linuxtx.org>
Content-Type: text/plain
Date: Thu, 01 Oct 2009 17:12:52 +0100
Message-Id: <1254413572.2920.37.camel@blaa>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Reply-To: Mark McLoughlin <markmc@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Justin M. Forbes" <jmforbes@linuxtx.org>
Cc: qemu-devel@nongnu.org

On Thu, 2009-10-01 at 09:42 -0500, Justin M. Forbes wrote:
> Author: Justin M. Forbes <jforbes@redhat.com>
> Date:   Thu Oct 1 09:34:56 2009 -0500
> 
>     Improve error reporting on file access
>     
>     By making the error reporting include strerror(errno), it gives the user
>     a bit more indication as to why qemu failed.  This is particularly
>     important for people running qemu as a non root user.
>     
>     Signed-off-by: Justin M. Forbes <jforbes@redhat.com>

Certainly looks sensible to me

Not having this is hurting us in Fedora 12 because we've started running
qemu as an unprivileged user and people are having a hard time figuring
out the various errors they're seeing caused by the change. This should
help them.

Only concern is that errno might not be getting propagated correctly by
some of these functions, but we can fix that later if so.

Cheers,
Mark.