From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mv7NO-0008AT-9X
	for qemu-devel@nongnu.org; Tue, 06 Oct 2009 06:34:38 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mv7NJ-00088F-3I
	for qemu-devel@nongnu.org; Tue, 06 Oct 2009 06:34:37 -0400
Received: from [199.232.76.173] (port=52634 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mv7NI-000885-Gg
	for qemu-devel@nongnu.org; Tue, 06 Oct 2009 06:34:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49821)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <markmc@redhat.com>) id 1Mv7NH-0000Ke-UY
	for qemu-devel@nongnu.org; Tue, 06 Oct 2009 06:34:32 -0400
Subject: Re: [Qemu-devel] [PATCH v3 4/5] Refactor RTC command line switches
From: Mark McLoughlin <markmc@redhat.com>
In-Reply-To: <20090915113604.8313.37848.stgit@mchn012c.ww002.siemens.net>
References: <20090915113603.8313.49563.stgit@mchn012c.ww002.siemens.net>
	<20090915113604.8313.37848.stgit@mchn012c.ww002.siemens.net>
Content-Type: text/plain
Date: Tue, 06 Oct 2009 11:32:54 +0100
Message-Id: <1254825174.2720.17.camel@blaa>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Reply-To: Mark McLoughlin <markmc@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Anthony Liguori <aliguori@us.ibm.com>, Dor Laor <dlaor@redhat.com>, Glauber Costa <glommer@redhat.com>, qemu-devel@nongnu.org

On Tue, 2009-09-15 at 13:36 +0200, Jan Kiszka wrote:
> Deprecate -localtime, -setdate and -rtc-td-hack in favor of a new
> unified command line switch:
> 
>     -rtc [base=utc|localtime|date][,driftfix=none|slew]
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> 
>  qemu-config.c   |   17 ++++++++
>  qemu-config.h   |    1 
>  qemu-options.hx |   47 ++++++++++++-----------
>  vl.c            |  111 ++++++++++++++++++++++++++++++++++++++-----------------
>  4 files changed, 119 insertions(+), 57 deletions(-)
> 
> diff --git a/qemu-config.c b/qemu-config.c
> index 39bf6a9..45a3e09 100644
> --- a/qemu-config.c
> +++ b/qemu-config.c
> @@ -151,6 +151,23 @@ QemuOptsList qemu_device_opts = {
>      },
>  };
>  
> +QemuOptsList qemu_rtc_opts = {
> +    .name = "rtc",
> +    .head = QTAILQ_HEAD_INITIALIZER(qemu_rtc_opts.head),
> +    .desc = {
> +        {
> +            .name = "base",
> +            .type = QEMU_OPT_STRING,
> +#ifdef TARGET_I386
> +        },{
> +            .name = "driftfix",
> +            .type = QEMU_OPT_STRING,
> +#endif
> +        },
> +        { /* end if list */ }
> +    },
> +};
> +
>  static QemuOptsList *lists[] = {
>      &qemu_drive_opts,
>      &qemu_chardev_opts,

Need to add qemu_rtc_opts to this list for -set

Cheers,
Mark.