From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mv84O-0006wj-Gu for qemu-devel@nongnu.org; Tue, 06 Oct 2009 07:19:04 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mv84G-0006rF-Fi for qemu-devel@nongnu.org; Tue, 06 Oct 2009 07:19:01 -0400 Received: from [199.232.76.173] (port=40403 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mv84E-0006q5-CE for qemu-devel@nongnu.org; Tue, 06 Oct 2009 07:18:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41994) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mv84D-0007sT-Gi for qemu-devel@nongnu.org; Tue, 06 Oct 2009 07:18:53 -0400 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n96BIqkU017677 for ; Tue, 6 Oct 2009 07:18:52 -0400 From: Mark McLoughlin Date: Tue, 6 Oct 2009 12:17:01 +0100 Message-Id: <1254827836-11021-12-git-send-email-markmc@redhat.com> In-Reply-To: <1254827783.2720.42.camel@blaa> References: <1254827783.2720.42.camel@blaa> Subject: [Qemu-devel] [PATCH] Remove double error message for -device option parsing List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Mark McLoughlin qemu_opts_parse() gives a suitable error message in all failure cases so we can remove the error message from the caller. Signed-off-by: Mark McLoughlin --- vl.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/vl.c b/vl.c index b7d370b..811f26d 100644 --- a/vl.c +++ b/vl.c @@ -5354,9 +5354,7 @@ int main(int argc, char **argv, char **envp) add_device_config(DEV_USB, optarg); break; case QEMU_OPTION_device: - opts = qemu_opts_parse(&qemu_device_opts, optarg, "driver"); - if (!opts) { - fprintf(stderr, "parse error: %s\n", optarg); + if (!qemu_opts_parse(&qemu_device_opts, optarg, "driver")) { exit(1); } break; -- 1.6.2.5