From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, avi@redhat.com
Subject: [Qemu-devel] [PATCH v2 00/15]: Initial QObject conversion
Date: Tue, 6 Oct 2009 21:26:57 -0300 [thread overview]
Message-ID: <1254875232-25012-1-git-send-email-lcapitulino@redhat.com> (raw)
Hi there,
Here goes another new version of my initial QObject conversion work.
I'm taking a different approach in this series. Instead of introducing
the error handling code along with the initial conversions, I'm only
doing the QObject conversion part.
This means that error information is still directly printed by the
command handler, but 'regular' data is returned to the Monitor in the
form of QObjects.
This approach makes the series easier to:
1. Review, as we can concentrate only on the QObject conversion
2. Convert & merge, as we can do only one thing at a time
3. Test, for the same reason as in '2'
The disadvantage is that we will need a 'second pass conversion' to
convert the error handling part, which can only be done when I finish
the QError data type I'm writing.
This is not a big issue anyway, as only two of nine conversions in
this series can fail.
The following handlers are being converted: do_quit(), do_stop(),
do_system_reset(), do_system_powerdown(), do_cont(), do_balloon(),
do_info_version(), do_info_balloon(), do_info_cpus().
Also, I'm introducing QList as it's needed by the do_info_cpus()
conversion.
I've done a full build of this series on F11 (x86_64) and
Debian Lenny (i386), manually tested all conversions and some other
commands.
Changelog:
V1 -> V2:
- Drop error handling code
- More handlers converted
V0 -> V1:
- Introduced MonitorError
- More handlers converted
- Improved patches descriptions
- Minor changes
diffstat:
Makefile | 3 +-
check-qlist.c | 153 +++++++++++++
configure | 2 +-
monitor.c | 599 +++++++++++++++++++++++++++++++++++++++---------
qemu-monitor.hx | 674 ++++++++++++++++++++++++++++++++++++++++++++----------
qlist.c | 100 ++++++++
qlist.h | 27 +++
qobject.h | 8 +-
8 files changed, 1322 insertions(+), 244 deletions(-)
next reply other threads:[~2009-10-07 0:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-07 0:26 Luiz Capitulino [this message]
2009-10-07 0:26 ` [Qemu-devel] [PATCH 01/15] QObject: Accept NULL Luiz Capitulino
2009-10-07 0:26 ` [Qemu-devel] [PATCH 02/15] Introduce QList Luiz Capitulino
2009-10-07 1:37 ` [Qemu-devel] " Anthony Liguori
2009-10-07 12:48 ` Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 03/15] Introduce QList unit-tests Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 04/15] monitor: Add user_print() to mon_cmd_t Luiz Capitulino
2009-10-07 1:40 ` [Qemu-devel] " Anthony Liguori
2009-10-07 12:52 ` Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 05/15] monitor: Handle new and old style handlers Luiz Capitulino
2009-10-07 1:42 ` [Qemu-devel] " Anthony Liguori
2009-10-07 12:54 ` Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 06/15] monitor: do_info(): handle new and old info handlers Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 07/15] monitor: Convert do_quit() do QObject Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 08/15] monitor: Convert do_stop() to QObject Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 09/15] monitor: Convert do_system_reset() " Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 10/15] monitor: Convert do_system_powerdown() " Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 11/15] monitor: Convert do_cont() " Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 12/15] monitor: Convert do_balloon() " Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 13/15] monitor: Convert do_info_version() " Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 14/15] monitor: Convert do_info_balloon() " Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 15/15] monitor: Convert do_info_cpus() " Luiz Capitulino
2009-10-07 1:46 ` [Qemu-devel] " Anthony Liguori
2009-10-07 13:04 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254875232-25012-1-git-send-email-lcapitulino@redhat.com \
--to=lcapitulino@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).