From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, avi@redhat.com
Subject: [Qemu-devel] [PATCH 12/15] monitor: Convert do_balloon() to QObject
Date: Tue, 6 Oct 2009 21:27:09 -0300 [thread overview]
Message-ID: <1254875232-25012-13-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1254875232-25012-1-git-send-email-lcapitulino@redhat.com>
It is important to note that it never fails, as big refactoring
of the virtio code would be needed to get the proper error code.
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
monitor.c | 6 ++++--
qemu-monitor.hx | 2 +-
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/monitor.c b/monitor.c
index 094b090..cb28ffb 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1603,8 +1603,10 @@ static void do_info_status(Monitor *mon)
monitor_printf(mon, "VM status: paused\n");
}
-
-static void do_balloon(Monitor *mon, const QDict *qdict)
+/**
+ * do_balloon(): Request VM to change its memory allocation
+ */
+static void do_balloon(Monitor *mon, const QDict *qdict, QObject **ret_data)
{
int value = qdict_get_int(qdict, "value");
ram_addr_t target = value;
diff --git a/qemu-monitor.hx b/qemu-monitor.hx
index 935e8ea..efaabea 100644
--- a/qemu-monitor.hx
+++ b/qemu-monitor.hx
@@ -917,7 +917,7 @@ ETEXI
.name = "balloon",
.args_type = "value:i",
.handler = do_balloon,
- .user_print = NULL,
+ .user_print = monitor_user_noop,
.params = "target",
.help = "request VM to change it's memory allocation (in MB)"
},
--
1.6.5.rc2.17.gdbc1b
next prev parent reply other threads:[~2009-10-07 0:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-07 0:26 [Qemu-devel] [PATCH v2 00/15]: Initial QObject conversion Luiz Capitulino
2009-10-07 0:26 ` [Qemu-devel] [PATCH 01/15] QObject: Accept NULL Luiz Capitulino
2009-10-07 0:26 ` [Qemu-devel] [PATCH 02/15] Introduce QList Luiz Capitulino
2009-10-07 1:37 ` [Qemu-devel] " Anthony Liguori
2009-10-07 12:48 ` Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 03/15] Introduce QList unit-tests Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 04/15] monitor: Add user_print() to mon_cmd_t Luiz Capitulino
2009-10-07 1:40 ` [Qemu-devel] " Anthony Liguori
2009-10-07 12:52 ` Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 05/15] monitor: Handle new and old style handlers Luiz Capitulino
2009-10-07 1:42 ` [Qemu-devel] " Anthony Liguori
2009-10-07 12:54 ` Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 06/15] monitor: do_info(): handle new and old info handlers Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 07/15] monitor: Convert do_quit() do QObject Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 08/15] monitor: Convert do_stop() to QObject Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 09/15] monitor: Convert do_system_reset() " Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 10/15] monitor: Convert do_system_powerdown() " Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 11/15] monitor: Convert do_cont() " Luiz Capitulino
2009-10-07 0:27 ` Luiz Capitulino [this message]
2009-10-07 0:27 ` [Qemu-devel] [PATCH 13/15] monitor: Convert do_info_version() " Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 14/15] monitor: Convert do_info_balloon() " Luiz Capitulino
2009-10-07 0:27 ` [Qemu-devel] [PATCH 15/15] monitor: Convert do_info_cpus() " Luiz Capitulino
2009-10-07 1:46 ` [Qemu-devel] " Anthony Liguori
2009-10-07 13:04 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254875232-25012-13-git-send-email-lcapitulino@redhat.com \
--to=lcapitulino@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).