From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MvUQa-0000C5-2l for qemu-devel@nongnu.org; Wed, 07 Oct 2009 07:11:28 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MvUQV-00007l-40 for qemu-devel@nongnu.org; Wed, 07 Oct 2009 07:11:27 -0400 Received: from [199.232.76.173] (port=46352 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MvUQU-00007i-W9 for qemu-devel@nongnu.org; Wed, 07 Oct 2009 07:11:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62058) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MvUQU-0007AK-Ix for qemu-devel@nongnu.org; Wed, 07 Oct 2009 07:11:22 -0400 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n97BBLq7014460 for ; Wed, 7 Oct 2009 07:11:21 -0400 From: Amit Shah Date: Wed, 7 Oct 2009 16:40:38 +0530 Message-Id: <1254913840-10358-2-git-send-email-amit.shah@redhat.com> In-Reply-To: <1254913840-10358-1-git-send-email-amit.shah@redhat.com> References: <1254913840-10358-1-git-send-email-amit.shah@redhat.com> Subject: [Qemu-devel] [PATCH 1/3] char: check for initial_reset_issued unnecessary List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Amit Shah At init, qemu_chr_reset is always called with initial_reset_issued set to 1. So checking for it to be set is not necessary. A later patch will make use of initial_reset_issued to send the reset event only if the char device is opened instead of each time when qemu resets it Signed-off-by: Amit Shah --- qemu-char.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 8084a67..99ab471 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -127,7 +127,7 @@ static void qemu_chr_reset_bh(void *opaque) void qemu_chr_reset(CharDriverState *s) { - if (s->bh == NULL && initial_reset_issued) { + if (s->bh == NULL) { s->bh = qemu_bh_new(qemu_chr_reset_bh, s); qemu_bh_schedule(s->bh); } @@ -137,11 +137,10 @@ void qemu_chr_initial_reset(void) { CharDriverState *chr; - initial_reset_issued = 1; - QTAILQ_FOREACH(chr, &chardevs, next) { qemu_chr_reset(chr); } + initial_reset_issued = 1; } int qemu_chr_write(CharDriverState *s, const uint8_t *buf, int len) -- 1.6.2.5