From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MvVlE-0008Ew-1r
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 08:36:52 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MvVl9-0008C1-N5
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 08:36:51 -0400
Received: from [199.232.76.173] (port=56748 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MvVl9-0008Bs-H6
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 08:36:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:19571)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MvVl8-0004PQ-JT
	for qemu-devel@nongnu.org; Wed, 07 Oct 2009 08:36:47 -0400
Received: from int-mx04.intmail.prod.int.phx2.redhat.com
	(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n97CakkT029084
	for <qemu-devel@nongnu.org>; Wed, 7 Oct 2009 08:36:46 -0400
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Wed,  7 Oct 2009 14:36:31 +0200
Message-Id: <1254918996-26050-1-git-send-email-kraxel@redhat.com>
Subject: [Qemu-devel] [RfC PATCH v2 0/5] qdev-ify network cards
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>

  Hi,

Short RfC patch series to get the discussion rolling.  We really need to
get the nic drivers qdev-ified properly, so qemu stops segfaulting on
'-device $any_nic_here'.

New in v2:
  * Fix some style nits and minor issues from review.
  * Don't hook up the nic to vlan 0 by default, in preparation to
    other ways coming to hook up nics.
  * Add pxe property for option rom loading.

To keep things small simple I've started with the ne2k_isa.  All the PCI
nics share the initialization path and thus I can't simply pick a single
one as example and convert it.

The network card can now be created using ...

  -device ne2k_isa,mac=00:11:22:33:44:55,vlan=1,irq=3,id=foo

'info qtree' shows ...

	[ ... ]
        bus: isa.0
          type ISA
          dev: ne2k_isa, id "foo"
            dev-prop: iobase = 0x300
            dev-prop: irq = 3
            dev-prop: vlan = 1
            dev-prop: mac = 00:11:22:33:44:55
            dev-prop: pxe = 0
	[ ... ]

'info network' shows:

	[ ... ]
	VLAN 1 devices:
	  foo: model=ne2k_isa,macaddr=00:11:22:33:44:55

With a vlan specified the nic initialization code calls
qemu_new_vlan_client() with the vlan specified using the vlan property.
Likewise the device cleanup code should call qemu_del_vlan_client.  You
don't see that in the patches though as ISA devices are not
hot-pluggable ;)

struct NICInfo is not needed at all here.  I hope we can kill it long-term.

This patch series is also available here:
  http://git.et.redhat.com/?p=qemu-kraxel.git;a=shortlog;h=refs/heads/nic.v2

cheers,
  Gerd