qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Amit Shah <amit.shah@redhat.com>
To: qemu-devel@nongnu.org
Cc: Amit Shah <amit.shah@redhat.com>
Subject: [Qemu-devel] [PATCH v2 0/3] Send out OPENED events only on chardev open
Date: Wed,  7 Oct 2009 18:31:14 +0530	[thread overview]
Message-ID: <1254920477-4645-1-git-send-email-amit.shah@redhat.com> (raw)

Hello,

These patches rename the CHR_EVENT_RESET event to CHR_EVENT_OPENED,
which is what it really is.

The check for initial_reset_issued was not really necessary, so that has
been done away with.

Finally, this event is now only sent when a char dev is opened instead
of the current behaviour of also sending it when qemu does its early
init of char state. The consumers of the event shouldn't be interested
in this anyway.

I've tested this with the monitor and made sure the events are emitted
only when a char dev is actually opened.

v2:
- Introduce a per-CharDriverState initial_reset_sent state bool that
  tracks whether the reset is for an init reset or an open event


Amit Shah (3):
  char: check for initial_reset_issued unnecessary
  char: rename CHR_EVENT_RESET to CHR_EVENT_OPENED
  char: emit the OPENED event only when a new char connection is opened

 gdbstub.c       |    2 +-
 hw/baum.c       |    2 +-
 hw/usb-serial.c |    2 +-
 monitor.c       |    2 +-
 qemu-char.c     |   12 +++++++-----
 qemu-char.h     |    4 +++-
 6 files changed, 14 insertions(+), 10 deletions(-)

             reply	other threads:[~2009-10-07 13:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-07 13:01 Amit Shah [this message]
2009-10-07 13:01 ` [Qemu-devel] [PATCH v2 1/3] char: check for initial_reset_issued unnecessary Amit Shah
2009-10-07 13:01   ` [Qemu-devel] [PATCH v2 2/3] char: rename CHR_EVENT_RESET to CHR_EVENT_OPENED Amit Shah
2009-10-07 13:01     ` [Qemu-devel] [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened Amit Shah
2009-10-24 10:36       ` [Qemu-devel] " Jan Kiszka
2009-10-26  3:53         ` Amit Shah
2009-10-26  7:40           ` Jan Kiszka
2009-10-26  9:28             ` Amit Shah
2009-10-26 20:15               ` Jan Kiszka
2009-10-27  7:46                 ` Amit Shah
2009-10-27  8:40                   ` Kevin Wolf
2009-10-27  9:20                     ` Amit Shah
2009-10-27 14:04                       ` Anthony Liguori
2009-10-27 14:14                         ` Amit Shah
2009-10-27 14:22                         ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1254920477-4645-1-git-send-email-amit.shah@redhat.com \
    --to=amit.shah@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).