From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MvW9Z-0001z6-PY for qemu-devel@nongnu.org; Wed, 07 Oct 2009 09:02:01 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MvW9V-0001u5-6R for qemu-devel@nongnu.org; Wed, 07 Oct 2009 09:02:01 -0400 Received: from [199.232.76.173] (port=40357 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MvW9U-0001tq-Fg for qemu-devel@nongnu.org; Wed, 07 Oct 2009 09:01:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19322) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MvW9T-0008I4-TL for qemu-devel@nongnu.org; Wed, 07 Oct 2009 09:01:56 -0400 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n97D1tR1011931 for ; Wed, 7 Oct 2009 09:01:55 -0400 From: Amit Shah Date: Wed, 7 Oct 2009 18:31:14 +0530 Message-Id: <1254920477-4645-1-git-send-email-amit.shah@redhat.com> Subject: [Qemu-devel] [PATCH v2 0/3] Send out OPENED events only on chardev open List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Amit Shah Hello, These patches rename the CHR_EVENT_RESET event to CHR_EVENT_OPENED, which is what it really is. The check for initial_reset_issued was not really necessary, so that has been done away with. Finally, this event is now only sent when a char dev is opened instead of the current behaviour of also sending it when qemu does its early init of char state. The consumers of the event shouldn't be interested in this anyway. I've tested this with the monitor and made sure the events are emitted only when a char dev is actually opened. v2: - Introduce a per-CharDriverState initial_reset_sent state bool that tracks whether the reset is for an init reset or an open event Amit Shah (3): char: check for initial_reset_issued unnecessary char: rename CHR_EVENT_RESET to CHR_EVENT_OPENED char: emit the OPENED event only when a new char connection is opened gdbstub.c | 2 +- hw/baum.c | 2 +- hw/usb-serial.c | 2 +- monitor.c | 2 +- qemu-char.c | 12 +++++++----- qemu-char.h | 4 +++- 6 files changed, 14 insertions(+), 10 deletions(-)