From: Amit Shah <amit.shah@redhat.com>
To: qemu-devel@nongnu.org
Cc: Amit Shah <amit.shah@redhat.com>
Subject: [Qemu-devel] [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened
Date: Wed, 7 Oct 2009 18:31:17 +0530 [thread overview]
Message-ID: <1254920477-4645-4-git-send-email-amit.shah@redhat.com> (raw)
In-Reply-To: <1254920477-4645-3-git-send-email-amit.shah@redhat.com>
The OPENED event gets sent also when qemu resets its state initially.
The consumers of the event aren't interested in receiving this event
on reset.
Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
qemu-char.c | 7 ++++++-
qemu-char.h | 2 ++
2 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 4757689..0fd402c 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -119,7 +119,12 @@ static void qemu_chr_event(CharDriverState *s, int event)
static void qemu_chr_reset_bh(void *opaque)
{
CharDriverState *s = opaque;
- qemu_chr_event(s, CHR_EVENT_OPENED);
+
+ if (s->initial_reset_issued) {
+ qemu_chr_event(s, CHR_EVENT_OPENED);
+ } else {
+ s->initial_reset_issued = true;
+ }
qemu_bh_delete(s->bh);
s->bh = NULL;
}
diff --git a/qemu-char.h b/qemu-char.h
index 05fe15d..409961d 100644
--- a/qemu-char.h
+++ b/qemu-char.h
@@ -1,6 +1,7 @@
#ifndef QEMU_CHAR_H
#define QEMU_CHAR_H
+#include <stdbool.h>
#include "qemu-common.h"
#include "qemu-queue.h"
#include "qemu-option.h"
@@ -66,6 +67,7 @@ struct CharDriverState {
QEMUBH *bh;
char *label;
char *filename;
+ bool initial_reset_issued;
QTAILQ_ENTRY(CharDriverState) next;
};
--
1.6.2.5
next prev parent reply other threads:[~2009-10-07 13:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-07 13:01 [Qemu-devel] [PATCH v2 0/3] Send out OPENED events only on chardev open Amit Shah
2009-10-07 13:01 ` [Qemu-devel] [PATCH v2 1/3] char: check for initial_reset_issued unnecessary Amit Shah
2009-10-07 13:01 ` [Qemu-devel] [PATCH v2 2/3] char: rename CHR_EVENT_RESET to CHR_EVENT_OPENED Amit Shah
2009-10-07 13:01 ` Amit Shah [this message]
2009-10-24 10:36 ` [Qemu-devel] Re: [PATCH v2 3/3] char: emit the OPENED event only when a new char connection is opened Jan Kiszka
2009-10-26 3:53 ` Amit Shah
2009-10-26 7:40 ` Jan Kiszka
2009-10-26 9:28 ` Amit Shah
2009-10-26 20:15 ` Jan Kiszka
2009-10-27 7:46 ` Amit Shah
2009-10-27 8:40 ` Kevin Wolf
2009-10-27 9:20 ` Amit Shah
2009-10-27 14:04 ` Anthony Liguori
2009-10-27 14:14 ` Amit Shah
2009-10-27 14:22 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254920477-4645-4-git-send-email-amit.shah@redhat.com \
--to=amit.shah@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).