qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, avi@redhat.com
Subject: [Qemu-devel] [PATCH 17/18] monitor: Convert do_info_balloon() to QObject
Date: Wed,  7 Oct 2009 13:42:03 -0300	[thread overview]
Message-ID: <1254933724-22485-18-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1254933724-22485-1-git-send-email-lcapitulino@redhat.com>

On success return a QInt with the balloon's value.

This also introduces monitor_print_balloon() to print the
balloon information in the user protocol.

Please, note that errors are not being converted yet.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 monitor.c |   16 +++++++++++++---
 1 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/monitor.c b/monitor.c
index 8c9cc9b..9983f34 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1633,7 +1633,16 @@ static void do_balloon(Monitor *mon, const QDict *qdict, QObject **ret_data)
     qemu_balloon(target << 20);
 }
 
-static void do_info_balloon(Monitor *mon)
+static void monitor_print_balloon(Monitor *mon, const QObject *data)
+{
+    monitor_printf(mon, "balloon: actual=%d\n",
+                                     (int)qint_get_int(qobject_to_qint(data)));
+}
+
+/**
+ * do_info_balloon(): Balloon information
+ */
+static void do_info_balloon(Monitor *mon, QObject **ret_data)
 {
     ram_addr_t actual;
 
@@ -1644,7 +1653,7 @@ static void do_info_balloon(Monitor *mon)
     else if (actual == 0)
         monitor_printf(mon, "Ballooning not activated in VM\n");
     else
-        monitor_printf(mon, "balloon: actual=%d\n", (int)(actual >> 20));
+        *ret_data = QOBJECT(qint_from_int((int)(actual >> 20)));
 }
 
 static qemu_acl *find_acl(Monitor *mon, const char *name)
@@ -2107,7 +2116,8 @@ static const mon_cmd_t info_cmds[] = {
         .args_type  = "",
         .params     = "",
         .help       = "show balloon information",
-        .mhandler.info = do_info_balloon,
+        .user_print = monitor_print_balloon,
+        .mhandler.info_new = do_info_balloon,
     },
     {
         .name       = "qtree",
-- 
1.6.5.rc2.17.gdbc1b

  parent reply	other threads:[~2009-10-07 16:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-07 16:41 [Qemu-devel] [RESEND v3 00/18]: Initial QObject conversion Luiz Capitulino
2009-10-07 16:41 ` [Qemu-devel] [PATCH 01/18] QObject: Accept NULL Luiz Capitulino
2009-10-07 16:41 ` [Qemu-devel] [PATCH 02/18] Introduce QList Luiz Capitulino
2009-10-07 16:41 ` [Qemu-devel] [PATCH 03/18] Introduce QList unit-tests Luiz Capitulino
2009-10-07 16:41 ` [Qemu-devel] [PATCH 04/18] monitor: Convert mon_cmd_t initializations to C99 style Luiz Capitulino
2009-10-07 16:41 ` [Qemu-devel] [PATCH 05/18] monitor: union for info handlers Luiz Capitulino
2009-10-07 16:41 ` [Qemu-devel] [PATCH 06/18] monitor: union for command handlers Luiz Capitulino
2009-10-07 16:41 ` [Qemu-devel] [PATCH 07/18] monitor: Add user_print() to mon_cmd_t Luiz Capitulino
2009-10-07 16:41 ` [Qemu-devel] [PATCH 08/18] monitor: Handle new and old style handlers Luiz Capitulino
2009-10-07 16:41 ` [Qemu-devel] [PATCH 09/18] monitor: do_info(): handle new and old info handlers Luiz Capitulino
2009-10-07 16:41 ` [Qemu-devel] [PATCH 10/18] monitor: Convert do_quit() do QObject Luiz Capitulino
2009-10-07 16:41 ` [Qemu-devel] [PATCH 11/18] monitor: Convert do_stop() to QObject Luiz Capitulino
2009-10-07 16:41 ` [Qemu-devel] [PATCH 12/18] monitor: Convert do_system_reset() " Luiz Capitulino
2009-10-07 16:41 ` [Qemu-devel] [PATCH 13/18] monitor: Convert do_system_powerdown() " Luiz Capitulino
2009-10-07 16:42 ` [Qemu-devel] [PATCH 14/18] monitor: Convert do_cont() " Luiz Capitulino
2009-10-07 16:42 ` [Qemu-devel] [PATCH 15/18] monitor: Convert do_balloon() " Luiz Capitulino
2009-10-07 16:42 ` [Qemu-devel] [PATCH 16/18] monitor: Convert do_info_version() " Luiz Capitulino
2009-10-07 16:42 ` Luiz Capitulino [this message]
2009-10-07 16:42 ` [Qemu-devel] [PATCH 18/18] monitor: Convert do_info_cpus() " Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1254933724-22485-18-git-send-email-lcapitulino@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).