From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MvvOy-0004lY-WE for qemu-devel@nongnu.org; Thu, 08 Oct 2009 11:59:37 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MvvOs-0004bB-Lb for qemu-devel@nongnu.org; Thu, 08 Oct 2009 11:59:35 -0400 Received: from [199.232.76.173] (port=57557 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MvvOs-0004ag-Ed for qemu-devel@nongnu.org; Thu, 08 Oct 2009 11:59:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21605) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MvvOr-0002JI-Nu for qemu-devel@nongnu.org; Thu, 08 Oct 2009 11:59:29 -0400 From: Gleb Natapov Date: Thu, 8 Oct 2009 17:59:08 +0200 Message-Id: <1255017566-26220-4-git-send-email-gleb@redhat.com> In-Reply-To: <1255017566-26220-1-git-send-email-gleb@redhat.com> References: <1255017566-26220-1-git-send-email-gleb@redhat.com> Subject: [Qemu-devel] [PATCH 03/21] Always create PCI interrupt override acpi tables. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: kevin@koconnor.net Cc: qemu-devel@nongnu.org This is what qemu pcbios does since commit da5ff65dc9473e3f069736d38b9a189ea14a67eb. Qemu implements PCI interrupts as active high, but OSes assume that they are active low as per PCI spec. Qemu works without override only because ioapic there doesn't implement polarity bit. Signed-off-by: Gleb Natapov --- src/acpi.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/src/acpi.c b/src/acpi.c index dafd8c8..1b4f4c5 100644 --- a/src/acpi.c +++ b/src/acpi.c @@ -196,12 +196,7 @@ struct madt_io_apic * lines start */ } PACKED; -#if CONFIG_KVM -/* IRQs 5,9,10,11 */ #define PCI_ISA_IRQ_MASK 0x0e20 -#else -#define PCI_ISA_IRQ_MASK 0x0000 -#endif struct madt_intsrcovr { APIC_HEADER_DEF -- 1.6.3.3