From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MxKtF-0001wn-S3
	for qemu-devel@nongnu.org; Mon, 12 Oct 2009 09:24:41 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MxKtB-0001v0-5r
	for qemu-devel@nongnu.org; Mon, 12 Oct 2009 09:24:41 -0400
Received: from [199.232.76.173] (port=40692 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MxKtB-0001uv-2H
	for qemu-devel@nongnu.org; Mon, 12 Oct 2009 09:24:37 -0400
Received: from mx1.redhat.com ([209.132.183.28]:32905)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <markmc@redhat.com>) id 1MxKtA-0004iS-Jl
	for qemu-devel@nongnu.org; Mon, 12 Oct 2009 09:24:36 -0400
Received: from int-mx03.intmail.prod.int.phx2.redhat.com
	(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n9CDOZlq031200
	for <qemu-devel@nongnu.org>; Mon, 12 Oct 2009 09:24:36 -0400
From: Mark McLoughlin <markmc@redhat.com>
In-Reply-To: <4AD32C35.5030206@redhat.com>
References: <1255028312-28180-1-git-send-email-markmc@redhat.com>
	<1255028312-28180-3-git-send-email-markmc@redhat.com>
	<4AD32C35.5030206@redhat.com>
Content-Type: text/plain
Date: Mon, 12 Oct 2009 14:22:55 +0100
Message-Id: <1255353775.3059.42.camel@blaa>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 02/16] hotplug: safely iterate bus's
 sibling list while removing a device
Reply-To: Mark McLoughlin <markmc@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On Mon, 2009-10-12 at 15:16 +0200, Gerd Hoffmann wrote:
> On 10/08/09 20:58, Mark McLoughlin wrote:
> > Without this, I'm seeing a segfault when unpluging a NIC.
> 
> Patch looks good.
> 
> I'm wondering I didn't see segfaults in my testing.  The bug doesn't 
> look nic-specific.  Where does it crash?

I didn't investigate in great detail, but it looked like it crashed
while trying to iterate the list after the qdev_free()

Cheers,
Mark.