From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mxjoe-0000k3-Gm
	for qemu-devel@nongnu.org; Tue, 13 Oct 2009 12:01:38 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mxjoa-0000ie-Rg
	for qemu-devel@nongnu.org; Tue, 13 Oct 2009 12:01:33 -0400
Received: from [199.232.76.173] (port=53887 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mxjoa-0000iU-FQ
	for qemu-devel@nongnu.org; Tue, 13 Oct 2009 12:01:32 -0400
Received: from adelie.canonical.com ([91.189.90.139]:57493)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kirkland@canonical.com>) id 1MxjoZ-0001lv-0G
	for qemu-devel@nongnu.org; Tue, 13 Oct 2009 12:01:31 -0400
Subject: Re: [Qemu-devel] [PATCH] hotplug: fix "pci_add storage if=scsi"
From: Dustin Kirkland <kirkland@canonical.com>
In-Reply-To: <4AD4A286.30005@codemonkey.ws>
References: <1255435195-27832-1-git-send-email-kraxel@redhat.com>
	<4AD4A286.30005@codemonkey.ws>
Content-Type: multipart/signed; micalg="pgp-sha1";
	protocol="application/pgp-signature";
	boundary="=-51uDAt9rDFM1WvSQUz5i"
Date: Tue, 13 Oct 2009 11:01:24 -0500
Message-Id: <1255449684.21570.24.camel@x200>
Mime-Version: 1.0
Reply-To: kirkland@canonical.com
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org


--=-51uDAt9rDFM1WvSQUz5i
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 2009-10-13 at 10:53 -0500, Anthony Liguori wrote:
> Gerd Hoffmann wrote:
> > Explicitly add the drive to the bus of the newly created scsi adapter
> > instead of hoping that scsi_bus_legacy_handle_cmdline() picks it up
> > correctly.
> >
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> >  =20
>=20
> I think that this is also broken in stable-0.11.  The backport seems=20
> non-trivial.  Could you take a look?

Definitely broken in stable-0.11.

I took a look at backporting this patch, but it seems that (at least) in
stable-0.11:
 * scsi_bus_legacy_handle_cmdline() doesn't exist
 * scsi_bus_new() syntax may have changed (?)
 * pci_create() syntax may have changed (?)

I'll gladly test and ack a backport ;-)


Thanks,
:-Dustin

--=-51uDAt9rDFM1WvSQUz5i
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEABECAAYFAkrUpFMACgkQs7pNXIOmEZTdHwCg1tI4dJoXxrFDkIJNoLwVlyUO
FncAnjuabo7yO2G26VZOhm4wn7exskvW
=KWkv
-----END PGP SIGNATURE-----

--=-51uDAt9rDFM1WvSQUz5i--