From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MxmUm-00063j-T9 for qemu-devel@nongnu.org; Tue, 13 Oct 2009 14:53:16 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MxmUi-000635-8D for qemu-devel@nongnu.org; Tue, 13 Oct 2009 14:53:16 -0400 Received: from [199.232.76.173] (port=58144 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MxmUi-000632-5v for qemu-devel@nongnu.org; Tue, 13 Oct 2009 14:53:12 -0400 Received: from smtp-out0.tiscali.nl ([195.241.79.175]:57201) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MxmUh-0003HZ-P2 for qemu-devel@nongnu.org; Tue, 13 Oct 2009 14:53:11 -0400 Subject: Re: [Qemu-devel] Re: [PATCH] usb-linux: return USB_RET_STALL on -EPIPE From: Paul Bolle In-Reply-To: <4AD4B791.8030203@qualcomm.com> References: <1255434008.1817.40.camel@localhost.localdomain> <4AD4849C.3000600@us.ibm.com> <1255449158.1679.11.camel@localhost.localdomain> <4AD4A51B.4080407@us.ibm.com> <1255450341.1679.20.camel@localhost.localdomain> <4AD4A943.60604@codemonkey.ws> <4AD4B791.8030203@qualcomm.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 13 Oct 2009 20:53:06 +0200 Message-Id: <1255459986.4712.6.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Krasnyansky Cc: Anthony Liguori , Mark Burkley , "qemu-devel@nongnu.org" On Tue, 2009-10-13 at 10:23 -0700, Max Krasnyansky wrote: > On 10/13/2009 09:22 AM, Anthony Liguori wrote: > > A SoB is a statement of intent so if you feel you can contribute a SoB > > is a decision for you to make. See Documentation/SubmittingPatches in > > Linux for more details about the ramification of DCO. > > I guess I could've provided the Signed-off-by instead of Acked-by. > In other words if you're ok with converting my Acked-By to > Signed-off-by in the aforementioned patch then lets go ahead an do it. > > I could also resend the full patch but I'm totally swamped right now and > might not get to doing it this week. > > btw Paul you can also resend and sign off yourself and keep my ack. I guess this patch should make everybody happy. I've replaced the verbose commit message with (basically) a longer version of the commit summary. A search for the summary should turn up this thread, which will in turn point to previous steps for those readers really interested. --- usb-linux: return USB_RET_STALL on -EPIPE If -EPIPE is returned to an asynchronous IN completion async_complete() should return USB_RET_STALL. Signed-off-by: Paul Bolle Cc: Mark Burkley Signed-off-by: Max Krasnyansky --- usb-linux.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/usb-linux.c b/usb-linux.c index 9e5d9c4..d712134 100644 --- a/usb-linux.c +++ b/usb-linux.c @@ -275,7 +275,9 @@ static void async_complete(void *opaque) case -EPIPE: set_halt(s, p->devep); - /* fall through */ + p->len = USB_RET_STALL; + break; + default: p->len = USB_RET_NAK; break; -- 1.6.5.rc2