From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MyCuO-0003Jo-8B for qemu-devel@nongnu.org; Wed, 14 Oct 2009 19:05:28 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MyCuJ-0003JM-Is for qemu-devel@nongnu.org; Wed, 14 Oct 2009 19:05:27 -0400 Received: from [199.232.76.173] (port=47547 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MyCuJ-0003JG-CI for qemu-devel@nongnu.org; Wed, 14 Oct 2009 19:05:23 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:58911) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MyCuI-0005gK-TC for qemu-devel@nongnu.org; Wed, 14 Oct 2009 19:05:23 -0400 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e9.ny.us.ibm.com (8.14.3/8.13.1) with ESMTP id n9EN1cYF003566 for ; Wed, 14 Oct 2009 19:01:38 -0400 Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id n9EN5LVn213326 for ; Wed, 14 Oct 2009 19:05:21 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n9EN5LPc010503 for ; Wed, 14 Oct 2009 19:05:21 -0400 Subject: Re: [Qemu-devel] [PATCH 6/9] QError: Add qdev not found error From: Hollis Blanchard In-Reply-To: <1255453026-18637-7-git-send-email-lcapitulino@redhat.com> References: <1255453026-18637-1-git-send-email-lcapitulino@redhat.com> <1255453026-18637-7-git-send-email-lcapitulino@redhat.com> Content-Type: text/plain Date: Wed, 14 Oct 2009 16:02:10 -0700 Message-Id: <1255561330.29192.2.camel@slab.beaverton.ibm.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, kraxel@redhat.com On Tue, 2009-10-13 at 13:57 -0300, Luiz Capitulino wrote: > Signed-off-by: Luiz Capitulino > --- > qerror.c | 12 ++++++++++++ > qerror.h | 1 + > 2 files changed, 13 insertions(+), 0 deletions(-) > > diff --git a/qerror.c b/qerror.c > index bbea770..88a8208 100644 > --- a/qerror.c > +++ b/qerror.c > @@ -24,11 +24,23 @@ static const QType qerror_type = { > .destroy = qerror_destroy_obj, > }; > > +static void qemu_err_qdev_nodev(const QError *qerror) > +{ > + QDict *qdict = qobject_to_qdict(qerror->data); > + qemu_error("Device \"%s\" not found. Try -device '?' for a list.\n", > + qdict_get_str(qdict, "name")); > +} > + > static QErrorTable qerror_table[] = { > { > .code = QERR_UNKNOWN, > .desc = "unknown error", > }, > + { > + .code = QERR_QDEV_NFOUND, > + .desc = "device not found", > + .user_print = qemu_err_qdev_nodev, > + }, > }; > > /** > diff --git a/qerror.h b/qerror.h > index ed25ef1..820f25e 100644 > --- a/qerror.h > +++ b/qerror.h > @@ -21,6 +21,7 @@ > */ > typedef enum QErrorCode { > QERR_UNKNOWN, > + QERR_QDEV_NFOUND, > QERR_MAX, > } QErrorCode; I'm not really seeing the point: what is gained by moving the error text from the original site into this function-inside-a-structure? -- Hollis Blanchard IBM Linux Technology Center