[Qemu-devel] [RfC PATCH v3 00/10] qdev-ify network cards

[Gerd Hoffmann <kraxel@redhat.com>]

  Hi,

Short RfC patch series to get the discussion rolling.  We really need to
get the nic drivers qdev-ified properly, so qemu stops segfaulting on
'-device $any_nic_here'.

New in v3:
  * renamed macaddr_t to MACAddr and made it a struct.
  * Adapted to netdev changes merged recently.
  * Also convert ne2k_pci.
  * Some new qdev properties and common bits for nics to ease
    conversion.
  * load pxe rom unconditionally (ne2k_pci only).

New in v2:
  * Fix some style nits and minor issues from review.
  * Don't hook up the nic to vlan 0 by default, in preparation to
    other ways coming to hook up nics.
  * Add pxe property for option rom loading.

To keep things small simple I've started with the ne2k_isa.  All the PCI
nics share the initialization path and thus I can't simply pick a single
one as example and convert it.

The network card can now be created using ...

  -device ne2k_isa,mac=00:11:22:33:44:55,vlan=1,irq=3,id=foo

'info qtree' shows ...

	[ ... ]
        bus: isa.0
          type ISA
          dev: ne2k_isa, id "foo"
            dev-prop: iobase = 0x300
            dev-prop: irq = 3
            dev-prop: mac = 00:11:22:33:44:55
            dev-prop: vlan = 1
            dev-prop: netdev = <null>
	[ ... ]

'info network' shows:

	[ ... ]
	VLAN 1 devices:
	  foo: model=ne2k_isa,macaddr=00:11:22:33:44:55

With a vlan specified the nic initialization code calls
qemu_new_vlan_client() with the vlan specified using the vlan property.
Likewise the device cleanup code should call qemu_del_vlan_client.

struct NICInfo is not needed at all here.  I hope we can kill it long-term.

This patch series is also available here:
  http://repo.or.cz/w/qemu/kraxel.git?a=shortlog;h=refs/heads/nic.v3

cheers,
  Gerd