qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [RfC PATCH v3 09/10] ne2k_pci: qdev-ify.
Date: Fri, 16 Oct 2009 15:42:02 +0200	[thread overview]
Message-ID: <1255700523-15270-10-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1255700523-15270-1-git-send-email-kraxel@redhat.com>


Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/ne2000.c |   27 +++++++++++++++++++++------
 1 files changed, 21 insertions(+), 6 deletions(-)

diff --git a/hw/ne2000.c b/hw/ne2000.c
index 7ce56ff..f296b10 100644
--- a/hw/ne2000.c
+++ b/hw/ne2000.c
@@ -758,22 +758,37 @@ static int pci_ne2000_init(PCIDevice *pci_dev)
                            PCI_ADDRESS_SPACE_IO, ne2000_map);
     s = &d->ne2000;
     s->irq = d->dev.irq[0];
-    qdev_get_macaddr(&d->dev.qdev, s->c.macaddr.a);
+
+    qemu_macaddr_default_if_unset(&s->c.macaddr);
     ne2000_reset(s);
-    s->vc = qdev_get_vlan_client(&d->dev.qdev,
+    s->vc = qemu_new_vlan_client(s->c.vlan, s->c.peer,
+                                 pci_dev->qdev.info->name, pci_dev->qdev.id,
                                  ne2000_can_receive, ne2000_receive, NULL,
                                  ne2000_cleanup, s);
-
     qemu_format_nic_info_str(s->vc, s->c.macaddr.a);
 
     register_savevm("ne2000", -1, 3, pci_ne2000_save, pci_ne2000_load, d);
     return 0;
 }
 
+static int pci_ne2000_exit(PCIDevice *pci_dev)
+{
+    PCINE2000State *d = DO_UPCAST(PCINE2000State, dev, pci_dev);
+    NE2000State *s = &d->ne2000;
+
+    qemu_del_vlan_client(s->vc);
+    return 0;
+}
+
 static PCIDeviceInfo ne2000_info = {
-    .qdev.name = "ne2k_pci",
-    .qdev.size = sizeof(PCINE2000State),
-    .init      = pci_ne2000_init,
+    .qdev.name  = "ne2k_pci",
+    .qdev.size  = sizeof(PCINE2000State),
+    .init       = pci_ne2000_init,
+    .exit       = pci_ne2000_exit,
+    .qdev.props = (Property[]) {
+        DEFINE_NIC_PROPERTIES(PCINE2000State, ne2000.c),
+        DEFINE_PROP_END_OF_LIST(),
+    }
 };
 
 static void ne2000_register_devices(void)
-- 
1.6.2.5

  parent reply	other threads:[~2009-10-16 13:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-16 13:41 [Qemu-devel] [RfC PATCH v3 00/10] qdev-ify network cards Gerd Hoffmann
2009-10-16 13:41 ` [Qemu-devel] [RfC PATCH v3 01/10] net: macaddr tweaks Gerd Hoffmann
2009-10-16 13:41 ` [Qemu-devel] [RfC PATCH v3 02/10] qdev: mac addr property fixups Gerd Hoffmann
2009-10-16 13:41 ` [Qemu-devel] [RfC PATCH v3 03/10] qdev: add netdev property Gerd Hoffmann
2009-10-16 13:41 ` [Qemu-devel] [RfC PATCH v3 04/10] qdev: add vlan property Gerd Hoffmann
2009-10-16 13:41 ` [Qemu-devel] [RfC PATCH v3 05/10] qdev/net: common nic property bits Gerd Hoffmann
2009-10-16 13:41 ` [Qemu-devel] [RfC PATCH v3 06/10] ne2k_isa: qdev-ify Gerd Hoffmann
2009-10-16 13:42 ` [Qemu-devel] [RfC PATCH v3 07/10] qdev: add qdev_prop_exists() Gerd Hoffmann
2009-10-16 13:42 ` [Qemu-devel] [RfC PATCH v3 08/10] prepare pci nic init path for qdev conversion Gerd Hoffmann
2009-10-16 13:42 ` Gerd Hoffmann [this message]
2009-10-16 13:42 ` [Qemu-devel] [RfC PATCH v3 10/10] ne2k_pci: load rom Gerd Hoffmann
2009-10-19  8:59 ` [Qemu-devel] [RfC PATCH v3 00/10] qdev-ify network cards Mark McLoughlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1255700523-15270-10-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).