qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 9/9] monitor: Convert do_closefd() to QObject
Date: Fri, 16 Oct 2009 12:23:51 -0300	[thread overview]
Message-ID: <1255706631-3742-10-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1255706631-3742-1-git-send-email-lcapitulino@redhat.com>

Note that errors are not being converted yet.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 monitor.c       |    2 +-
 qemu-monitor.hx |    3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/monitor.c b/monitor.c
index f35b55f..3d82ab8 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1889,7 +1889,7 @@ static void do_getfd(Monitor *mon, const QDict *qdict, QObject **ret_data)
     QLIST_INSERT_HEAD(&mon->fds, monfd, next);
 }
 
-static void do_closefd(Monitor *mon, const QDict *qdict)
+static void do_closefd(Monitor *mon, const QDict *qdict, QObject **ret_data)
 {
     const char *fdname = qdict_get_str(qdict, "fdname");
     mon_fd_t *monfd;
diff --git a/qemu-monitor.hx b/qemu-monitor.hx
index cc4487e..bb01c14 100644
--- a/qemu-monitor.hx
+++ b/qemu-monitor.hx
@@ -1029,7 +1029,8 @@ ETEXI
         .args_type  = "fdname:s",
         .params     = "closefd name",
         .help       = "close a file descriptor previously passed via SCM rights",
-        .mhandler.cmd = do_closefd,
+        .user_print = monitor_user_noop,
+        .mhandler.cmd_new = do_closefd,
     },
 
 STEXI
-- 
1.6.5.rc3.8.g8ba5e

      parent reply	other threads:[~2009-10-16 15:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-16 15:23 [Qemu-devel] [PATCH 0/9]: Simple QObject conversions Luiz Capitulino
2009-10-16 15:23 ` [Qemu-devel] [PATCH 1/9] monitor: Convert do_memory_save() to QObject Luiz Capitulino
2009-10-16 15:23 ` [Qemu-devel] [PATCH 2/9] monitor: Convert do_physical_memory_save() " Luiz Capitulino
2009-10-16 15:23 ` [Qemu-devel] [PATCH 3/9] monitor: Convert do_migrate() " Luiz Capitulino
2009-10-16 15:23 ` [Qemu-devel] [PATCH 4/9] monitor: Convert do_migrate_set_speed() " Luiz Capitulino
2009-10-16 15:23 ` [Qemu-devel] [PATCH 5/9] monitor: Convert do_migrate_cancel() " Luiz Capitulino
2009-10-16 15:23 ` [Qemu-devel] [PATCH 6/9] monitor: Convert do_pci_device_hot_remove() " Luiz Capitulino
2009-10-16 15:23 ` [Qemu-devel] [PATCH 7/9] monitor: Convert do_eject() " Luiz Capitulino
2009-10-16 15:23 ` [Qemu-devel] [PATCH 8/9] monitor: Convert do_getfd() " Luiz Capitulino
2009-10-16 15:23 ` Luiz Capitulino [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1255706631-3742-10-git-send-email-lcapitulino@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).