From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 6/9] monitor: Convert do_pci_device_hot_remove() to QObject
Date: Fri, 16 Oct 2009 12:23:48 -0300 [thread overview]
Message-ID: <1255706631-3742-7-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1255706631-3742-1-git-send-email-lcapitulino@redhat.com>
Errors are still directly printed, as we are only converting
regular output.
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
hw/pci-hotplug.c | 3 ++-
qemu-monitor.hx | 3 ++-
sysemu.h | 3 ++-
3 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/hw/pci-hotplug.c b/hw/pci-hotplug.c
index 35fa290..ad9893a 100644
--- a/hw/pci-hotplug.c
+++ b/hw/pci-hotplug.c
@@ -230,7 +230,8 @@ void pci_device_hot_remove(Monitor *mon, const char *pci_addr)
qdev_unplug(&d->qdev);
}
-void do_pci_device_hot_remove(Monitor *mon, const QDict *qdict)
+void do_pci_device_hot_remove(Monitor *mon, const QDict *qdict,
+ QObject **ret_data)
{
pci_device_hot_remove(mon, qdict_get_str(qdict, "pci_addr"));
}
diff --git a/qemu-monitor.hx b/qemu-monitor.hx
index 41fbfd3..4610ad4 100644
--- a/qemu-monitor.hx
+++ b/qemu-monitor.hx
@@ -816,7 +816,8 @@ ETEXI
.args_type = "pci_addr:s",
.params = "[[<domain>:]<bus>:]<slot>",
.help = "hot remove PCI device",
- .mhandler.cmd = do_pci_device_hot_remove,
+ .user_print = monitor_user_noop,
+ .mhandler.cmd_new = do_pci_device_hot_remove,
},
#endif
diff --git a/sysemu.h b/sysemu.h
index 763861d..d91ef67 100644
--- a/sysemu.h
+++ b/sysemu.h
@@ -211,7 +211,8 @@ void destroy_nic(dev_match_fn *match_fn, void *arg);
void pci_device_hot_add(Monitor *mon, const QDict *qdict);
void drive_hot_add(Monitor *mon, const QDict *qdict);
void pci_device_hot_remove(Monitor *mon, const char *pci_addr);
-void do_pci_device_hot_remove(Monitor *mon, const QDict *qdict);
+void do_pci_device_hot_remove(Monitor *mon, const QDict *qdict,
+ QObject **ret_data);
void pci_device_hot_remove_success(PCIDevice *dev);
/* serial ports */
--
1.6.5.rc3.8.g8ba5e
next prev parent reply other threads:[~2009-10-16 15:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-16 15:23 [Qemu-devel] [PATCH 0/9]: Simple QObject conversions Luiz Capitulino
2009-10-16 15:23 ` [Qemu-devel] [PATCH 1/9] monitor: Convert do_memory_save() to QObject Luiz Capitulino
2009-10-16 15:23 ` [Qemu-devel] [PATCH 2/9] monitor: Convert do_physical_memory_save() " Luiz Capitulino
2009-10-16 15:23 ` [Qemu-devel] [PATCH 3/9] monitor: Convert do_migrate() " Luiz Capitulino
2009-10-16 15:23 ` [Qemu-devel] [PATCH 4/9] monitor: Convert do_migrate_set_speed() " Luiz Capitulino
2009-10-16 15:23 ` [Qemu-devel] [PATCH 5/9] monitor: Convert do_migrate_cancel() " Luiz Capitulino
2009-10-16 15:23 ` Luiz Capitulino [this message]
2009-10-16 15:23 ` [Qemu-devel] [PATCH 7/9] monitor: Convert do_eject() " Luiz Capitulino
2009-10-16 15:23 ` [Qemu-devel] [PATCH 8/9] monitor: Convert do_getfd() " Luiz Capitulino
2009-10-16 15:23 ` [Qemu-devel] [PATCH 9/9] monitor: Convert do_closefd() " Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1255706631-3742-7-git-send-email-lcapitulino@redhat.com \
--to=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).