From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: Michael Roth <michael.roth@amd.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH] qapi: Remove QMP events and commands from user-mode builds
Date: Wed, 24 Feb 2021 18:35:38 +0100 [thread overview]
Message-ID: <12557ba5-e8c1-80ca-8a51-1d7319372d35@redhat.com> (raw)
In-Reply-To: <20210224171642.3242293-1-philmd@redhat.com>
On 24/02/21 18:16, Philippe Mathieu-Daudé wrote:
> We removed the QMP loop in user-mode builds in commit 1935e0e4e09
> ("qapi/meson: Remove QMP from user-mode emulation"), now commands
> and events code is unreachable.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> qapi/meson.build | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/qapi/meson.build b/qapi/meson.build
> index 0652569bc43..fcb15a78f15 100644
> --- a/qapi/meson.build
> +++ b/qapi/meson.build
> @@ -102,11 +102,15 @@
> 'qapi-types-@0@.h'.format(module),
> 'qapi-visit-@0@.c'.format(module),
> 'qapi-visit-@0@.h'.format(module),
> - 'qapi-events-@0@.c'.format(module),
> - 'qapi-events-@0@.h'.format(module),
> - 'qapi-commands-@0@.c'.format(module),
> - 'qapi-commands-@0@.h'.format(module),
> ]
> + if have_system or have_tools
> + qapi_module_outputs += [
> + 'qapi-events-@0@.c'.format(module),
> + 'qapi-events-@0@.h'.format(module),
> + 'qapi-commands-@0@.c'.format(module),
> + 'qapi-commands-@0@.h'.format(module),
> + ]
> + endif
> if module.endswith('-target')
> qapi_specific_outputs += qapi_module_outputs
> else
>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
next prev parent reply other threads:[~2021-02-24 17:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 17:16 [PATCH] qapi: Remove QMP events and commands from user-mode builds Philippe Mathieu-Daudé
2021-02-24 17:35 ` Paolo Bonzini [this message]
2021-02-25 9:41 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12557ba5-e8c1-80ca-8a51-1d7319372d35@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=michael.roth@amd.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).