* [PATCH] qapi: Remove QMP events and commands from user-mode builds
@ 2021-02-24 17:16 Philippe Mathieu-Daudé
2021-02-24 17:35 ` Paolo Bonzini
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-02-24 17:16 UTC (permalink / raw)
To: qemu-devel
Cc: Michael Roth, Philippe Mathieu-Daudé, Markus Armbruster,
Paolo Bonzini
We removed the QMP loop in user-mode builds in commit 1935e0e4e09
("qapi/meson: Remove QMP from user-mode emulation"), now commands
and events code is unreachable.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
qapi/meson.build | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/qapi/meson.build b/qapi/meson.build
index 0652569bc43..fcb15a78f15 100644
--- a/qapi/meson.build
+++ b/qapi/meson.build
@@ -102,11 +102,15 @@
'qapi-types-@0@.h'.format(module),
'qapi-visit-@0@.c'.format(module),
'qapi-visit-@0@.h'.format(module),
- 'qapi-events-@0@.c'.format(module),
- 'qapi-events-@0@.h'.format(module),
- 'qapi-commands-@0@.c'.format(module),
- 'qapi-commands-@0@.h'.format(module),
]
+ if have_system or have_tools
+ qapi_module_outputs += [
+ 'qapi-events-@0@.c'.format(module),
+ 'qapi-events-@0@.h'.format(module),
+ 'qapi-commands-@0@.c'.format(module),
+ 'qapi-commands-@0@.h'.format(module),
+ ]
+ endif
if module.endswith('-target')
qapi_specific_outputs += qapi_module_outputs
else
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] qapi: Remove QMP events and commands from user-mode builds
2021-02-24 17:16 [PATCH] qapi: Remove QMP events and commands from user-mode builds Philippe Mathieu-Daudé
@ 2021-02-24 17:35 ` Paolo Bonzini
2021-02-25 9:41 ` Markus Armbruster
0 siblings, 1 reply; 3+ messages in thread
From: Paolo Bonzini @ 2021-02-24 17:35 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: Michael Roth, Markus Armbruster
On 24/02/21 18:16, Philippe Mathieu-Daudé wrote:
> We removed the QMP loop in user-mode builds in commit 1935e0e4e09
> ("qapi/meson: Remove QMP from user-mode emulation"), now commands
> and events code is unreachable.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> qapi/meson.build | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/qapi/meson.build b/qapi/meson.build
> index 0652569bc43..fcb15a78f15 100644
> --- a/qapi/meson.build
> +++ b/qapi/meson.build
> @@ -102,11 +102,15 @@
> 'qapi-types-@0@.h'.format(module),
> 'qapi-visit-@0@.c'.format(module),
> 'qapi-visit-@0@.h'.format(module),
> - 'qapi-events-@0@.c'.format(module),
> - 'qapi-events-@0@.h'.format(module),
> - 'qapi-commands-@0@.c'.format(module),
> - 'qapi-commands-@0@.h'.format(module),
> ]
> + if have_system or have_tools
> + qapi_module_outputs += [
> + 'qapi-events-@0@.c'.format(module),
> + 'qapi-events-@0@.h'.format(module),
> + 'qapi-commands-@0@.c'.format(module),
> + 'qapi-commands-@0@.h'.format(module),
> + ]
> + endif
> if module.endswith('-target')
> qapi_specific_outputs += qapi_module_outputs
> else
>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] qapi: Remove QMP events and commands from user-mode builds
2021-02-24 17:35 ` Paolo Bonzini
@ 2021-02-25 9:41 ` Markus Armbruster
0 siblings, 0 replies; 3+ messages in thread
From: Markus Armbruster @ 2021-02-25 9:41 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Michael Roth, Philippe Mathieu-Daudé, qemu-devel
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 24/02/21 18:16, Philippe Mathieu-Daudé wrote:
>> We removed the QMP loop in user-mode builds in commit 1935e0e4e09
>> ("qapi/meson: Remove QMP from user-mode emulation"), now commands
>> and events code is unreachable.
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> qapi/meson.build | 12 ++++++++----
>> 1 file changed, 8 insertions(+), 4 deletions(-)
>> diff --git a/qapi/meson.build b/qapi/meson.build
>> index 0652569bc43..fcb15a78f15 100644
>> --- a/qapi/meson.build
>> +++ b/qapi/meson.build
>> @@ -102,11 +102,15 @@
>> 'qapi-types-@0@.h'.format(module),
>> 'qapi-visit-@0@.c'.format(module),
>> 'qapi-visit-@0@.h'.format(module),
>> - 'qapi-events-@0@.c'.format(module),
>> - 'qapi-events-@0@.h'.format(module),
>> - 'qapi-commands-@0@.c'.format(module),
>> - 'qapi-commands-@0@.h'.format(module),
>> ]
>> + if have_system or have_tools
>> + qapi_module_outputs += [
>> + 'qapi-events-@0@.c'.format(module),
>> + 'qapi-events-@0@.h'.format(module),
>> + 'qapi-commands-@0@.c'.format(module),
>> + 'qapi-commands-@0@.h'.format(module),
>> + ]
>> + endif
>> if module.endswith('-target')
>> qapi_specific_outputs += qapi_module_outputs
>> else
>>
>
> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
I'm taking this as "Markus, care to take this through your tree?"
Queued, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-25 9:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-24 17:16 [PATCH] qapi: Remove QMP events and commands from user-mode builds Philippe Mathieu-Daudé
2021-02-24 17:35 ` Paolo Bonzini
2021-02-25 9:41 ` Markus Armbruster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).