qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Mark McLoughlin <markmc@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu: work around for "posix-aio-compat"
Date: Tue, 20 Oct 2009 19:39:41 +0100	[thread overview]
Message-ID: <1256063981.27918.6.camel@blaa> (raw)
In-Reply-To: <20091008203740.GA20727@redhat.com>

On Thu, 2009-10-08 at 22:37 +0200, Michael S. Tsirkin wrote:
> With commit ee3993069ff55fa6f1c64daf1e09963e340db8e4,
> "posix-aio-compat: avoid signal race when spawning a thread"
> winxp installation on a raw format file fails
> during disk format, with a message "your
> disk may be damaged".
> 
> This commit moved signal mask from aio thread to creating thread.
> It turns out if we keep the mask in aio thread as well, the problem
> disappears. It should not be needed, but since this is harmless, let's
> keep it around until someone inclined to debug pthread library internals
> can check this issue.
> 
> While we are at it, convert sigprocmask to pthread_sigmask
> as per posix.

FWIW, I just started hitting a boot hang with qemu.git and --enable-kvm
on a Fedora 11 machine with a Fedora 11 guest.

I bisected it back to malc's commit, found this thread, applied
Michael's patch and confirmed that it fixes the problem for me too.

Cheers,
Mark.

  parent reply	other threads:[~2009-10-20 18:42 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-08 20:37 [Qemu-devel] [PATCH] qemu: work around for "posix-aio-compat" Michael S. Tsirkin
2009-10-08 20:53 ` [Qemu-devel] " malc
2009-10-08 21:13   ` malc
2009-10-08 21:46     ` Michael S. Tsirkin
2009-10-08 22:17       ` malc
2009-10-08 23:19         ` Michael S. Tsirkin
2009-10-09  1:06           ` [Qemu-devel] Emulated network cards Natalia Portillo
2009-10-09  8:54             ` Luca Tettamanti
2009-10-09 13:05               ` Natalia Portillo
2009-10-09 13:16           ` [Qemu-devel] Re: [PATCH] qemu: work around for "posix-aio-compat" malc
2009-10-08 21:00 ` Michael S. Tsirkin
2009-10-20 18:39 ` Mark McLoughlin [this message]
2009-10-20 18:57   ` Paolo Bonzini
2009-10-21 15:42     ` Michael S. Tsirkin
2009-10-21 15:54       ` Michael S. Tsirkin
2009-10-21 17:28       ` Paolo Bonzini
2009-10-21 17:35         ` Michael S. Tsirkin
2009-10-21 17:44           ` Paolo Bonzini
2009-10-21 17:46             ` Michael S. Tsirkin
2009-10-21 18:38               ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1256063981.27918.6.camel@blaa \
    --to=markmc@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).